[Home]

Summary:ASTERISK-28049: res_pjproject build failure
Reporter:Jaco Kroon (jkroon)Labels:pjsip
Date Opened:2018-09-11 15:12:11Date Closed:2018-09-13 07:10:11
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:pjproject/pjsip
Versions:13.24.0 Frequency of
Occurrence
Related
Issues:
Environment:LinuxAttachments:
Description:{noformat}
  [CC] res_pjproject.c -> res_pjproject.o
res_pjproject.c: In function 'ast_sockaddr_to_pj_sockaddr':
res_pjproject.c:493:27: error: incompatible types when assigning to type 'pj_in_addr {aka struct pj_in_addr}' from type 'struct in_addr'
  pjaddr->ipv4.sin_addr   = sin->sin_addr;
                          ^
res_pjproject.c: In function 'ast_sockaddr_from_pj_sockaddr':
res_pjproject.c:514:19: error: incompatible types when assigning to type 'struct in_addr' from type 'pj_in_addr {aka const struct pj_in_addr}'
  sin->sin_addr   = pjaddr->ipv4.sin_addr;
                  ^
{noformat}

Introduced by:
{noformat}
commit b0ef54af717147dc369728a88bf6d4994abb4d12
Author: Sean Bright <sean.bright@gmail.com>
Date:   Tue Aug 28 09:42:13 2018 -0400

   res_pjproject: Add utility functions to convert between socket structures
   
   Currently, to convert from a pj_sockaddr to an ast_sockaddr, the address
   needs to be rendered to a string and then parsed into the correct
   structure. This also involves a call to getaddrinfo(3). The same is true
   for the inverse operation.
   
   Instead, because we know the internal structure of both ast_sockaddr and
   pj_sockaddr, we can translate directly between the two without the
   need for an intermediate string.
   
   Change-Id: If0fc4bba9643f755604c6ffbb0d7cc46020bc761
{noformat}
According to Joshua due to unbundled PJSIP, but still needs to work with unbundled.  Thus setting to MAJOR even though for me this is CRITICAL (distro prohibits bundled packages as far as possible).
Comments:By: Asterisk Team (asteriskteam) 2018-09-11 15:12:13.210-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

By: Friendly Automation (friendly-automation) 2018-09-13 07:10:11.807-0500

Change 10098 merged by Jenkins2:
res_pjproject: Fix sockaddr conversion routines for non-bundled PJSIP

[https://gerrit.asterisk.org/10098|https://gerrit.asterisk.org/10098]

By: Friendly Automation (friendly-automation) 2018-09-13 07:10:14.458-0500

Change 10099 merged by Jenkins2:
res_pjproject: Fix sockaddr conversion routines for non-bundled PJSIP

[https://gerrit.asterisk.org/10099|https://gerrit.asterisk.org/10099]

By: Friendly Automation (friendly-automation) 2018-09-13 07:11:28.991-0500

Change 10097 merged by Joshua Colp:
res_pjproject: Fix sockaddr conversion routines for non-bundled PJSIP

[https://gerrit.asterisk.org/10097|https://gerrit.asterisk.org/10097]

By: Friendly Automation (friendly-automation) 2018-09-13 07:12:21.027-0500

Change 10100 merged by Joshua Colp:
res_pjproject: Fix sockaddr conversion routines for non-bundled PJSIP

[https://gerrit.asterisk.org/10100|https://gerrit.asterisk.org/10100]