| Summary: | ASTERISK-28055: app_queue: Per-member wrapup time missing from AddQueueMember application | ||||
| Reporter: | Niksa Baldun (niksa) | Labels: | |||
| Date Opened: | 2018-09-14 08:09:00 | Date Closed: | 2019-03-22 14:08:16 | ||
| Priority: | Minor | Regression? | No | ||
| Status: | Closed/Complete | Components: | Applications/app_queue | ||
| Versions: | 16.0.0 | Frequency of Occurrence | |||
| Related Issues: |
| ||||
| Environment: | Attachments: | ||||
| Description: | Per-member wrapup time setting was introduced in v16, but it was not added to AddQueueMember application (I assume by omission), so it can't be set for dynamic members. | ||||
| Comments: | By: Asterisk Team (asteriskteam) 2018-09-14 08:09:01.234-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Joshua C. Colp (jcolp) 2018-09-14 09:41:52.228-0500 Is this something you plan on working on yourself and contributing? By: Niksa Baldun (niksa) 2018-09-14 14:32:24.666-0500 I wasn't planning to. My knowledge of Asterisk internals is very limited. I assumed that whoever implemented this feature simply forgot to cover dynamic members and I wanted to report that. By: Joshua C. Colp (jcolp) 2018-09-18 05:29:22.756-0500 I'm suspending this issue as adding support to AddQueueMember for this would be a new feature. If you or [~roramirez] (the individual who did the original patch) would like to pursue this then it can be reopened. By: Niksa Baldun (niksa) 2018-09-18 08:04:17.348-0500 I suggest that the [whatsnew|https://wiki.asterisk.org/wiki/display/AST/New+in+16] page for 16 be changed to say "A wrapup time can now be configured on a per-member basis *for static members*". The way it's currently worded, I'd say it's reasonable to assume that it can be set for both static and dynamic members. If I find the time to implement this myself, I will of course submit the patch. By: Asterisk Team (asteriskteam) 2018-09-18 08:04:17.597-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable. By: Joshua C. Colp (jcolp) 2018-09-18 08:08:28.111-0500 The wiki page has been updated. By: Friendly Automation (friendly-automation) 2019-02-26 06:36:27.054-0600 Change 10928 merged by Joshua C. Colp: app_queue: Enable set the wrapuptime from AddQueueMember application [https://gerrit.asterisk.org/10928|https://gerrit.asterisk.org/10928] By: Friendly Automation (friendly-automation) 2019-02-26 06:53:42.467-0600 Change 10785 merged by Friendly Automation: app_queue: Enable set the wrapuptime from AddQueueMember application [https://gerrit.asterisk.org/10785|https://gerrit.asterisk.org/10785] By: Niksa Baldun (niksa) 2019-03-22 09:21:28.638-0500 Thanks for implementing this functionality. It just occurred to me, member login can also be performed via AMI. Was QueueAdd AMI action also updated to include wrapup time? By: Asterisk Team (asteriskteam) 2019-03-22 09:21:28.926-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable. By: Benjamin Keith Ford (bford) 2019-03-22 14:08:04.488-0500 It appears that the manager function for QueueAdd was updated in this review, so it should be a part of this patch. If you find that to not be the case, open this ticket back up or create another to let us know! | ||||