| Summary: | ASTERISK-28067: res_pjsip_sdp_rtp: Extra fingerprint attribute in SDP | ||
| Reporter: | Salah Ahmed (rubel) | Labels: | patch pjsip |
| Date Opened: | 2018-09-21 08:49:32 | Date Closed: | |
| Priority: | Minor | Regression? | |
| Status: | In Progress/In Progress | Components: | Resources/res_pjsip_sdp_rtp |
| Versions: | 13.20.0 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | A-leg endpoint is configured as media_encryption = dtls media_encryption_optimistic = yes media_use_received_transport = yes In B-leg endpoint there have no any srtp related configuration. | Attachments: | ( 0) extra_attribute_in_sdp.patch |
| Description: | In this above scenario if we make a call between 2 clients and the incoming call has no dtls params in the sdp, the call is successful but in SDP on 200 Ok which asterisk sends to the A-side contains an extra attribute "fingerprint". So A -side endpoint gets confused and ends up rejecting the call.
In another case, if media_use_received_transport=no flag and both media_encryption = dtls and media_encryption_optimistic = yes then call gets answered but media port 0 is sent to the A-Party. So I think it should reject the call if incoming call have no dtls capability as asterisk have no support optimistic dtls. we built a simple patch for this issue, this patch does not implement optimistic dtls but with this inbound optimistic will work. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2018-09-21 08:49:33.791-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Joshua C. Colp (jcolp) 2018-09-21 09:02:09.801-0500 If you want to attach a patch for this for reference that is fine, but this is not something I'd see being included without fully supporting optimistic DTLS. By: Salah Ahmed (rubel) 2018-09-21 09:49:25.021-0500 Hello, Here we attached the patch. Thanks | ||