| Summary: | ASTERISK-28079: [patch]core: New variables CONNECTED_LINE_ORIGINAL_* for interception routine CONNECTED_LINE_SEND_SUB | ||
| Reporter: | Alexei Gradinari (alexei gradinari) | Labels: | |
| Date Opened: | 2018-09-27 12:16:28 | Date Closed: | 2018-10-05 09:42:56 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Core/Channels |
| Versions: | 13.23.1 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Added new variables
CONNECTED_LINE_ORIGINAL_ID_NUM CONNECTED_LINE_ORIGINAL_ID_NAME CONNECTED_LINE_ORIGINAL_ANI_NUM CONNECTED_LINE_ORIGINAL_ANI_NAME to get the original values inside the interception routine CONNECTED_LINE_SEND_SUB. It can help to prevent Connected Line update by reverting to original values or alter Connected Line information based on original values. | ||
| Comments: | By: Asterisk Team (asteriskteam) 2018-09-27 12:16:29.188-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Richard Mudgett (rmudgett) 2018-09-28 12:56:43.004-0500 This patch is not necessary. When you get a connected line update, the connected line information is already set to the new connected party (Bob) because you are no longer connected to the old party (Alice). There is no relationship between the old and the new information because Bob is not Alice. Thus in the normal case this patch wastes resources setting up channel variables and allocating memory that is not needed. The only reason to revert the connected line information is if you wanted it to stay constant. There are already several ways to get the constant information to reset the connected line information. These ways do not require any changes to Asterisk and incur the storage overhead only when this behavior is needed. I already provided example dialplan in this other review https://gerrit.asterisk.org/#/c/asterisk/+/10286/ to do just that. By: Alexei Gradinari (alexei gradinari) 2018-10-05 09:42:57.005-0500 This patch is not necessary. | ||