Summary:	ASTERISK-28094: pjsip. Disable anonymous for local sip domains and force to inbound registration
Reporter:	Dmitriy Serov (Demon)	Labels:	patch pjsip
Date Opened:	2018-10-05 16:35:19	Date Closed:	2018-10-09 05:27:06
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_pjsip_endpoint_identifier_anonymous
Versions:	15.6.1	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) res_pjsip_endpoint_identifier_anonymous.patch
Description:	A typical server has local users. And often the server allows incoming calls from other SIP servers that can not be authorized. Therefore, anonymous must be allowed on the server. But if someone makes a call using my domain (from), why should the server allow such a call without authentication? https://blogs.asterisk.org/2018/02/07/identifying-endpoint-pjsip/ The way anonymous@<domain> does not solve this problem. The solution would be to be able to create some anonymous@other or anonymous@external that would be used for "others" or "non-local". Another solution would be to add the anonymous_disable=yes option to the DOMAIN_ALIAS section But it's not easy for my level of programming. I just added just one line to the code (patch attached), which forces authentication of anyone who dares to specify my local domains in the from field
Comments:	By: Asterisk Team (asteriskteam) 2018-10-05 16:35:22.296-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Joshua C. Colp (jcolp) 2018-10-09 05:27:06.689-0500 This would be a feature request and unfortunately as you've mentioned the patch provided is not acceptable as it breaks previous behavior and is not configurable. If someone else would like to pick up this issue we can reopen it and that new change can be put up for review.