ASTERISK-28113: gerrit: Minor Tweak to email template to support dark theme.

[Home]

Summary: ASTERISK-28113: gerrit: Minor Tweak to email template to support dark theme.

Reporter: Corey Farrell (coreyfarrell) Labels:

Date Opened: 2018-10-17 16:43:57 Date Closed: 2018-11-02 14:23:38

Priority: Minor Regression?

Status: Closed/Complete Components: General

Versions: GIT Frequency of
Occurrence

Related
Issues:

Environment: Attachments:

Description: I have my email client configured with a dark theme, including display of white text on black background. This works well with one exception, when gerrit sends an email containing a vote the "Code-Review +1" is set to {{background-color: #d4ffd4}}. The template does not set the text color so it is white in my configuration (unreadable). I'd appreciate if you could add {{color: black}} to CommentHtml.soy in the voteStyle section:
{noformat}
{let $voteStyle kind="css"}
border-radius: 3px;
display: inline-block;
margin: 0 2px;
padding: 4px;
color: black;
{/let}
{noformat}

This will have no effect on most people but will make the vote readable in the color scheme of my client.

Comments: By: Asterisk Team (asteriskteam) 2018-10-17 16:43:57.692-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].