Summary:	ASTERISK-28129: Incorrect Behavior for rewrite_contact when Re-Invite omits routset
Reporter:	Torrey Searle (tsearle)	Labels:	pjsip
Date Opened:	2018-10-24 07:36:51	Date Closed:	2018-11-18 08:47:12.000-0600
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Resources/res_pjsip_nat
Versions:	13.24.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:
Description:	A routeset cannot be modified after the a SIP Dialog is created, thus the appearance of Record-Route headers in REINVITES is optional. res_pjsip_nat is designed to update the contact with received ip if there is no routset, and the topmost route header if there is a routset.  However if a re-invite omits adding Record-Route headers on a dialog that has a routset, res_pjsip_nat incorrectly updates the contact header causing subsequent messages asterisk sends to no be routed correctly.
Comments:	By: Asterisk Team (asteriskteam) 2018-10-24 07:36:52.600-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Friendly Automation (friendly-automation) 2018-11-18 08:47:14.449-0600 Change 10531 merged by George Joseph: res/res_pjsip_nat: Fix logic for REINVITES [https://gerrit.asterisk.org/10531|https://gerrit.asterisk.org/10531] By: Friendly Automation (friendly-automation) 2018-11-18 08:47:55.639-0600 Change 10558 merged by George Joseph: res/res_pjsip_nat: Fix logic for REINVITES [https://gerrit.asterisk.org/10558|https://gerrit.asterisk.org/10558] By: Friendly Automation (friendly-automation) 2018-11-18 08:48:13.314-0600 Change 10559 merged by George Joseph: res/res_pjsip_nat: Fix logic for REINVITES [https://gerrit.asterisk.org/10559|https://gerrit.asterisk.org/10559]