[Home]

Summary:ASTERISK-28162: [patch] need to reset DTMF last sequence number and timestamp on RTP renegotiation
Reporter:Alexei Gradinari (alexei gradinari)Labels:
Date Opened:2018-11-12 17:12:24.000-0600Date Closed:2019-01-14 08:02:21.000-0600
Priority:MajorRegression?
Status:Closed/CompleteComponents:Resources/res_rtp_asterisk
Versions:13.24.0 16.1.0 Frequency of
Occurrence
Related
Issues:
causesASTERISK-28200 res_rtp_asterisk: Duplicate DTMF with endpoint when media received in between
Environment:Attachments:
Description:The remote side may start a new stream when renegotiating RTP.
Need to reset the DTMF last sequence number and the timestamp
of the last END packet on RTP renegotiation.

If the new time stamp is lower then the timestamp of the last DTMF END packet the asterisk drops all DTMF frames as out of order.

This bug was caught using Cisco ip-phone SPA5XX and codec g722.
On SIP session update the SPA50X resets stream and a new timestamp is twice smaller then the previous.
Comments:By: Asterisk Team (asteriskteam) 2018-11-12 17:12:25.720-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Friendly Automation (friendly-automation) 2018-11-26 13:46:36.103-0600

Change 10623 merged by Jenkins2:
RTP: need to reset DTMF last seqno/timestamp on voice packet with marker bit

[https://gerrit.asterisk.org/10623|https://gerrit.asterisk.org/10623]
By: Friendly Automation (friendly-automation) 2018-11-26 13:48:15.673-0600

Change 10706 merged by Joshua Colp:
RTP: need to reset DTMF last seqno/timestamp on voice packet with marker bit

[https://gerrit.asterisk.org/10706|https://gerrit.asterisk.org/10706]
By: Friendly Automation (friendly-automation) 2018-11-26 13:48:38.080-0600

Change 10705 merged by Joshua Colp:
RTP: need to reset DTMF last seqno/timestamp on voice packet with marker bit

[https://gerrit.asterisk.org/10705|https://gerrit.asterisk.org/10705]
By: Alexei Gradinari (alexei gradinari) 2018-12-13 10:19:25.162-0600

Need to re-open it and remove "Target Release: 13.24.0, 16.1.0"
as commit If18ab1166db0d634ce8a099bd7460251e9c682e1 reverted it.

By: Asterisk Team (asteriskteam) 2018-12-13 10:19:25.592-0600

This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable.
By: Friendly Automation (friendly-automation) 2019-01-14 08:02:23.106-0600

Change 10829 merged by Friendly Automation:
RTP: reset DTMF last seqno/timestamp on RTP renegotiation

[https://gerrit.asterisk.org/10829|https://gerrit.asterisk.org/10829]
By: Friendly Automation (friendly-automation) 2019-01-14 08:04:25.813-0600

Change 10850 merged by Joshua C. Colp:
RTP: reset DTMF last seqno/timestamp on RTP renegotiation

[https://gerrit.asterisk.org/10850|https://gerrit.asterisk.org/10850]
By: Friendly Automation (friendly-automation) 2019-01-14 08:05:12.206-0600

Change 10851 merged by Joshua C. Colp:
RTP: reset DTMF last seqno/timestamp on RTP renegotiation

[https://gerrit.asterisk.org/10851|https://gerrit.asterisk.org/10851]