[Home]

Summary:ASTERISK-28168: app_queue: Adding a blank entry into sql queue_members crashes asterisk.
Reporter:Michael (ringo)Labels:pjsip
Date Opened:2018-11-16 12:19:14.000-0600Date Closed:2019-03-05 08:52:35.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Applications/app_queue
Versions:16.0.0 Frequency of
Occurrence		Constant
Related
Issues:
Environment:debian 9 amd64 asterisk v16 LTS using pjsip mysql ODBCAttachments:( 0) core.tar.gz
Description:Even though it is incorrect, adding a blank 'interface' name into queue_members sql table seems to crash asterisk.

eg.
insert into queue_members (queue_name, interface, membername, state_interface) values ('support','','Mike','');

EDIT:
Steps to reproduce:
# Add a realtime queue
# Add a queue member with an interface of ''
# Either dial into queue or do a "queue show" in the CLI
Comments:By: Asterisk Team (asteriskteam) 2018-11-16 12:19:16.422-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Kevin Harwell (kharwell) 2018-11-16 15:24:45.226-0600

Thank you for the crash report. However, we need more information to investigate the crash. Please provide:

1. A backtrace generated from a core dump using the instructions provided on the Asterisk wiki [1].
2. Specific steps taken that lead to the crash.
3. All configuration information necesary to reproduce the crash.

Thanks!

[1]: https://wiki.asterisk.org/wiki/display/AST/Getting+a+Backtrace


By: Michael (ringo) 2018-11-19 11:26:04.476-0600

core dump file processed with ast_coredumper as per instructions.  Thanks.
By: Michael (ringo) 2018-11-19 11:30:16.102-0600

2.
insert a queue member into a queue, and then dial into that queue.
ie.
insert into queue_members (queue_name, interface, membername, state_interface) values ('viapbx-techsupport','','Mike','');

even though the interfaces entry should not be blank, i still felt it was bug worthy.

3. not much configuration, just a configured queue, and then a Queue app entry to dial into it.  Crash's immediatly.


By: Benjamin Keith Ford (bford) 2018-11-20 14:03:22.739-0600

Yep, seems like you can just do a "queue show" on the CLI as well to reproduce this after adding the entry. Going to go ahead and open this one up.
By: Friendly Automation (friendly-automation) 2019-03-05 08:52:35.967-0600

Change 11096 merged by Friendly Automation:
app_queue: Handle empty 'interface' in queue member config

[https://gerrit.asterisk.org/c/asterisk/+/11096|https://gerrit.asterisk.org/c/asterisk/+/11096]
By: Friendly Automation (friendly-automation) 2019-03-05 08:52:45.317-0600

Change 11094 merged by Friendly Automation:
app_queue: Handle empty 'interface' in queue member config

[https://gerrit.asterisk.org/c/asterisk/+/11094|https://gerrit.asterisk.org/c/asterisk/+/11094]
By: Friendly Automation (friendly-automation) 2019-03-05 08:57:04.260-0600

Change 11095 merged by Joshua Colp:
app_queue: Handle empty 'interface' in queue member config

[https://gerrit.asterisk.org/c/asterisk/+/11095|https://gerrit.asterisk.org/c/asterisk/+/11095]