Summary:	ASTERISK-28182: chan_pjsip: When connected_line_method is set to invite, asterisk is not trying UPDATE
Reporter:	nappsoft (nappsoft)	Labels:	patch pjsip
Date Opened:	2018-11-26 07:33:34.000-0600	Date Closed:	2018-12-12 10:53:09.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Third-Party/pjproject
Versions:	13.23.1	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) UPDATE.patch
Description:	In ASTERISK-27095 there has been a fix for this issue. However this only solved the issue for incoming INVITES. For outgoing INVITES (important when transferring calls) the options need to be updated at a different place (see attached patch, which seems to solve the issue for me).
Comments:	By: Asterisk Team (asteriskteam) 2018-11-26 07:33:35.937-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. By: Benjamin Keith Ford (bford) 2018-11-26 09:43:27.794-0600 Are you wanting to put this patch up for review on Gerrit? By: nappsoft (nappsoft) 2018-11-26 13:48:57.036-0600 As I do not know much about the asterisk pjsip patch naming conventions, I think that it would be by far more efficient if an asterisk core team member would take a look at it and submit it (if it looks acceptable)? Otherwise I'd have to upload the patch at least 5 times until all of you guys are happy with it ;) By: Benjamin Keith Ford (bford) 2018-11-27 11:07:17.633-0600 The patch itself looks sane to me - as far as the naming convention for third-party patches, it should follow a format similar to this: {code} ####-what_this_patch_does.patch {code} The number should be an increment of 10 from the last patch in there, which for the case of 13 branch and at the time of posting this would be 0010 (only 0000 patch files are in there at the moment). For example, your patch could be: {code} 0010-outgoing_connected_line_method_update.patch {code} We would love it if you would push this up to Gerrit, let me know if you have any other questions or concerns about this! By: nappsoft (nappsoft) 2018-11-28 01:59:36.814-0600 I've checked in the patch. One thing to note (the reason why I discovered this in the end): In the following scenario asterisk will not notify C at all without the patch (asterisk only sends the Reinvite when the call has already been answered but not if it's still Ringing. But UPDATE messages do work during Ringing): A calls B (B answers the call) B starts a new call to C B transfers A to C while C did not yet pickup the call By: Friendly Automation (friendly-automation) 2018-12-12 10:53:10.757-0600 Change 10722 merged by George Joseph: pjproject_bundled: check whether UPDATE is supported on outgoing calls [https://gerrit.asterisk.org/10722|https://gerrit.asterisk.org/10722] By: Friendly Automation (friendly-automation) 2018-12-12 10:53:21.191-0600 Change 10717 merged by George Joseph: pjproject_bundled: check whether UPDATE is supported on outgoing calls [https://gerrit.asterisk.org/10717|https://gerrit.asterisk.org/10717] By: Friendly Automation (friendly-automation) 2018-12-12 11:02:51.295-0600 Change 10721 merged by Joshua C. Colp: pjproject_bundled: check whether UPDATE is supported on outgoing calls [https://gerrit.asterisk.org/10721|https://gerrit.asterisk.org/10721]