| Summary: | ASTERISK-28212: stasis: Statistics broke ABI under developer mode | ||
| Reporter: | Joshua C. Colp (jcolp) | Labels: | |
| Date Opened: | 2018-12-17 07:17:50.000-0600 | Date Closed: | 2019-01-03 17:40:37.000-0600 |
| Priority: | Major | Regression? | Yes |
| Status: | Closed/Complete | Components: | Core/Stasis |
| Versions: | 16.0.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | When built under developer mode ABI isn't preserved for a few bits of Stasis now. We should try to... rectify this. | ||
| Comments: | By: Corey Farrell (coreyfarrell) 2018-12-17 09:16:25.376-0600 I think master should use the current devmode ABI with file/line/func arguments unconditionally compiled in. For 13/16 my vote would be to just provide ABI compatibility stubs at the end of stasis.c and stasis_message_router.c. That would make DEVMODE asterisk compatible with non-devmode binary modules. Nobody should be compiling binary modules with devmode enabled so I don't think it's a big deal that stasis users compiled for latest with devmode enabled will not be compatible with older versions of Asterisk. By: Friendly Automation (friendly-automation) 2019-01-03 17:40:38.022-0600 Change 10841 merged by Friendly Automation: stasis: Fix ABI between DEVMODE and non-DEVMODE. [https://gerrit.asterisk.org/10841|https://gerrit.asterisk.org/10841] By: Friendly Automation (friendly-automation) 2019-01-03 17:40:40.381-0600 Change 10842 merged by Friendly Automation: stasis: Fix ABI between DEVMODE and non-DEVMODE. [https://gerrit.asterisk.org/10842|https://gerrit.asterisk.org/10842] By: Friendly Automation (friendly-automation) 2019-01-04 07:57:18.469-0600 Change 10840 merged by George Joseph: stasis: Fix ABI between DEVMODE and non-DEVMODE. [https://gerrit.asterisk.org/10840|https://gerrit.asterisk.org/10840] | ||