[Home]

Summary:ASTERISK-28222: Regression: MWI polling no longer works
Reporter:abelbeck (abelbeck)Labels:patch
Date Opened:2018-12-21 16:10:49.000-0600Date Closed:2018-12-26 11:16:22.000-0600
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:13.24.0 16.1.0 Frequency of
Occurrence		Constant
Related
Issues:
is related toASTERISK-27121 res_pjsip_mwi: Memory leak on reload
Environment:AstLinux 1.3.5-devAttachments:( 0) asterisk-13-revert-94a4eea7-stop_caching_stasis_subscription_change.patch
( 1) e137086.diff
Description:Just prior to the 13.24.0 release, this "app_voicemail: Remove need to subscribe to stasis" commit got reverted:

Revert "app_voicemail: Remove need to subscribe to stasis"
http://git.asterisk.org/gitweb/?p=asterisk/asterisk.git;a=commit;h=363d19326be4032dc93e08c379d9d6560a6e1e2f

But related, this stasis_cache commit depended on the original commit:

stasis_cache:  Stop caching stasis subscription change
http://git.asterisk.org/gitweb/?p=asterisk/asterisk.git;a=commit;h=94a4eea7f6e486368b35585ea867479f248095c2

Without also reverting the "Stop caching stasis subscription change" commit, MWI polling no longer works.

For example with 13.24.0, externally moving a voicemail file from "Old" to "INBOX" did not generate a MWI via polling.  Asterisk 13.23.1 worked fine.

I have tested reverting the 94a4eea "Stop caching stasis subscription change" commit to 13.24.0 and it fixes the problem.
Comments:By: Asterisk Team (asteriskteam) 2018-12-21 16:10:51.156-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: abelbeck (abelbeck) 2018-12-21 22:01:38.285-0600

Manually reverted 94a4eea7 patch for testing.

May solve other MWI issues with 13.24.0/16.1.0 as well.
By: George Joseph (gjoseph) 2018-12-24 08:17:22.065-0600

Lonnie,  Try the patch for 13 I just attached and see if it fixes the issue.  I'm not sure that it will in your case but let's see.




By: abelbeck (abelbeck) 2018-12-24 09:15:56.857-0600

George, no, the e137086.diff patch does not fix the problem ... in fact I tried that a couple days ago per your upstream commit of it.

Fundamentally, the 94a4eea7 commit required the 363d1932 commit, and 363d1932 got reverted, so 94a4eea7 needs to be reverted as well.

By: George Joseph (gjoseph) 2018-12-24 09:35:23.343-0600

Yeah it was a long shot.  We'll get it sorted today.

By: George Joseph (gjoseph) 2018-12-24 09:39:58.100-0600

Just for clarification...If you just revert the "revert" commit that went in before the release (363d19326be4032dc93e08c379d9d6560a6e1e2f) , does polling work as expected?

By: abelbeck (abelbeck) 2018-12-24 09:43:24.164-0600

Yes, reverting 363d1932 solved the problem, so that let me down the path that something depended on the original commit.
By: Friendly Automation (friendly-automation) 2018-12-26 11:16:22.924-0600

Change 10834 merged by Friendly Automation:
Revert "stasis_cache:  Stop caching stasis subscription change messages"

[https://gerrit.asterisk.org/10834|https://gerrit.asterisk.org/10834]
By: Friendly Automation (friendly-automation) 2018-12-26 11:29:17.073-0600

Change 10833 merged by Friendly Automation:
Revert "stasis_cache:  Stop caching stasis subscription change messages"

[https://gerrit.asterisk.org/10833|https://gerrit.asterisk.org/10833]
By: Friendly Automation (friendly-automation) 2018-12-26 11:35:57.643-0600

Change 10838 merged by George Joseph:
Revert "stasis_cache:  Stop caching stasis subscription change messages"

[https://gerrit.asterisk.org/10838|https://gerrit.asterisk.org/10838]
By: Friendly Automation (friendly-automation) 2018-12-26 11:36:21.381-0600

Change 10839 merged by George Joseph:
Revert "stasis_cache:  Stop caching stasis subscription change messages"

[https://gerrit.asterisk.org/10839|https://gerrit.asterisk.org/10839]
By: Friendly Automation (friendly-automation) 2018-12-26 11:36:47.763-0600

Change 10835 merged by George Joseph:
Revert "stasis_cache:  Stop caching stasis subscription change messages"

[https://gerrit.asterisk.org/10835|https://gerrit.asterisk.org/10835]
By: Friendly Automation (friendly-automation) 2018-12-26 11:37:06.314-0600

Change 10836 merged by George Joseph:
Revert "stasis_cache:  Stop caching stasis subscription change messages"

[https://gerrit.asterisk.org/10836|https://gerrit.asterisk.org/10836]
By: Friendly Automation (friendly-automation) 2018-12-26 11:37:21.886-0600

Change 10837 merged by George Joseph:
Revert "stasis_cache:  Stop caching stasis subscription change messages"

[https://gerrit.asterisk.org/10837|https://gerrit.asterisk.org/10837]