Summary:	ASTERISK-28263: codec_opus: errors setting max_playback_rate and bitrate to "sdp"
Reporter:	Gianluca Merlo (gian)	Labels:
Date Opened:	2019-01-25 10:01:48.000-0600	Date Closed:	2019-01-28 07:44:53.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Codecs/codec_opus
Versions:	16.1.1	Frequency of Occurrence	Constant
Related Issues:
Environment:	codec_opus: Remote package version 16.0_1.3.0 (263680) from http://downloads.digium.com/pub/telephony/codec_opus/asterisk-16.0/x86-64/codec_opus-16.0_1.3.0-x86_64.tar.gz Automatically installed during "make install"	Attachments:
Description:	Hello, configuration samples ({{configs/samples/codecs.conf.sample}}) provide the following explanation for two {{codec_opus}} options: {noformat} ;max_playback_rate= ; Override the maximum playback rate in the offer's SDP.                    ; Any value between 8000 and 48000 (inclusive) is valid,                    ; however typically it should match one of the usual opus                    ; bandwidths. A value of "sdp" is also allowed. When set                    ; to "sdp" then the value from the offer's SDP is used.                    ; (default: "sdp") ;bitrate= ; Override the maximum average bitrate in the offer's SDP. Any value          ; between 500 and 512000 is valid. The following values are also          ; allowed: auto, max, sdp. When set to "sdp" then the value from          ; the offer's sdp is used. (default: "sdp") {noformat} but explicitly setting {noformat} max_playback_rate=sdp bitrate=sdp {noformat} in a valid {{type=opus}} section results in an error like {noformat} config_options.c:798 aco_process_var: Error parsing bitrate=sdp [...] {noformat} when left to the default values, set to numeric values or to other documented values, there are no errors. Maybe the samples are outdated or {{codec_opus}} needs to be fixed to correctly parse these options? Thank you in advance for your help.
Comments:	By: Asterisk Team (asteriskteam) 2019-01-25 10:01:49.848-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Kevin Harwell (kharwell) 2019-01-25 12:16:23.223-0600 That option value was removed and the .conf file was not updated. The following wiki page should hopefully reflect the current state of things: https://wiki.asterisk.org/wiki/display/AST/Codec+Opus By: Gianluca Merlo (gian) 2019-01-28 05:54:57.118-0600 Thank you for the clarification, and for updating the sample. If I may, the wiki page (https://wiki.asterisk.org/wiki/display/AST/Codec+Opus) does actually exemplify the use of {{bitrate}}, but the same is not included in the parameter table. The sample does however carry clear documentation about it. By: Friendly Automation (friendly-automation) 2019-01-28 07:44:54.266-0600 Change 10927 merged by Friendly Automation: codecs.conf.sample: update codec opus docs [https://gerrit.asterisk.org/10927|https://gerrit.asterisk.org/10927] By: Friendly Automation (friendly-automation) 2019-01-28 07:48:16.767-0600 Change 10926 merged by George Joseph: codecs.conf.sample: update codec opus docs [https://gerrit.asterisk.org/10926|https://gerrit.asterisk.org/10926] By: Friendly Automation (friendly-automation) 2019-01-28 07:48:34.939-0600 Change 10925 merged by George Joseph: codecs.conf.sample: update codec opus docs [https://gerrit.asterisk.org/10925|https://gerrit.asterisk.org/10925] By: Kevin Harwell (kharwell) 2019-01-28 09:46:49.183-0600 Yep thanks for noticing. I've now updated the table on the wiki to include the bitrate as well.