Summary:	ASTERISK-28322: chan_pjsip: Add option to allow ignoring of 183 without SDP
Reporter:	Torrey Searle (tsearle)	Labels:	pjsip
Date Opened:	2019-03-04 01:50:11.000-0600	Date Closed:	2019-03-11 08:51:26
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Channels/chan_pjsip
Versions:	13.20.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	chan_sip is designed to explicitly ignore 183 messages if no sdp is found.  chan_pjsip however will instead forward a 183 with sdp instead.  This results in a lack of a ringback tone for impacted users. This patch adds a new flag to endpoints allowing the user to have the chan_sip behavior if desired.
Comments:	By: Asterisk Team (asteriskteam) 2019-03-04 01:50:12.068-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Ross Beer (rossbeer) 2019-03-04 03:51:05.216-0600 Isn't the correct behaviour to forward a 183 with no SDP so that the client generates ringing? By: Torrey Searle (tsearle) 2019-03-04 03:59:35.035-0600 That is up to debate, in the case I'm encountering customer generates a 180 followed by a 183 w/o sdp. According to the SIP-I spec, 183 with no sdp (just ISUP) payload can be generated for ss7 internetworking.  However it says that if you are not using profile-c (e.g. not sending ss7 messages) then the 183 is "not internetworked" which I interpret as dropping the 183 fully as a legitimate response. I agree that chan_pjsip should probably be enhanced to add support for fowarding 183 w/o sdp at some point in the future, but at this stage I'm only seeking to keep feature parity. By: Torrey Searle (tsearle) 2019-03-04 04:00:40.453-0600 also the proposed tests submitted do not check for sdp in the flag disabled & no sdp sent flow. Thus they are "future safe" if digium decides to implement 183 w/o sdp in the future. By: Torrey Searle (tsearle) 2019-03-04 04:45:59.890-0600 this is a port of the following fix from chan_sip ASTERISK-6481 commit 5a2b0d6c2b908140e6005067766737f459d81a50 Author: Olle Johansson <oej@edvina.net> Date:   Wed Mar 8 10:54:40 2006 +0000    Issue #6657 - Ignore 183 Session Progress without SDP (imported from 1.2 rev 12458)            git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@12459 65c4cc65-6c06-0410-ace0-fbb531ad65f3 By: Friendly Automation (friendly-automation) 2019-03-11 08:51:26.767-0500 Change 11086 merged by Friendly Automation: chan_pjsip: add a flag to ignore 183 responses if no SDP present [https://gerrit.asterisk.org/c/asterisk/+/11086|https://gerrit.asterisk.org/c/asterisk/+/11086] By: Friendly Automation (friendly-automation) 2019-03-11 08:55:16.059-0500 Change 11101 merged by Friendly Automation: chan_pjsip: add a flag to ignore 183 responses if no SDP present [https://gerrit.asterisk.org/c/asterisk/+/11101|https://gerrit.asterisk.org/c/asterisk/+/11101] By: Friendly Automation (friendly-automation) 2019-03-12 10:11:52.393-0500 Change 11102 merged by Friendly Automation: chan_pjsip: add a flag to ignore 183 responses if no SDP present [https://gerrit.asterisk.org/c/asterisk/+/11102|https://gerrit.asterisk.org/c/asterisk/+/11102]