Summary:	ASTERISK-28327: res_pjsip_endpoint_identifier_ip: Missing IdentifyDetail event
Reporter:	Stefano Fancello (Stell0)	Labels:	pjsip
Date Opened:	2019-03-07 07:23:05.000-0600	Date Closed:	2019-03-11 07:55:51
Priority:	Minor	Regression?	Yes
Status:	Closed/Complete	Components:	Resources/res_pjsip_endpoint_identifier_ip
Versions:	13.23.0 13.24.0 13.25.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:	( 0) pjsip.aor.conf ( 1) pjsip.auth.conf ( 2) pjsip.identify.conf
Description:	Since Asterisk 13.23.0, when I launch PJSIPShowEndpoint command from AMI, I don’t recive IdentifyDetail event anymore. *Step to reproduce:* - login to AMI - launch {{Action: PJSIPShowEndpoint}} {{Endpoint: an_existing_endpoint_here}} *Expected behavior* - I should see an {{IdentifyDetail}} event *Actual behavior* - Other events are displayed but not {{IdentifyDetail}}
Comments:	By: Asterisk Team (asteriskteam) 2019-03-07 07:23:05.765-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Sean Bright (seanbright) 2019-03-07 16:04:45.226-0600 I'm not able to reproduce this. Can you attach a sample configuration that demonstrates the problem? By: Stefano Fancello (Stell0) 2019-03-08 03:54:58.370-0600 using same configuration on 13.22.0, I've: Action: PJSIPShowEndpoint Endpoint: 206 ... Event: IdentifyDetail ObjectType: identify ObjectName: 206-identify Match: SrvLookups: true Endpoint: 206 MatchHeader: EndpointName: 206 ... if I add match=endpoint ip to pjsip.identify.conf, the issue is no more reproducible and I've: Action: PJSIPShowEndpoint Endpoint: 206 ... Event: IdentifyDetail ObjectType: identify ObjectName: 206-identify Match: 192.168.122.1/255.255.255.255 SrvLookups: true Endpoint: 206 MatchHeader: EndpointName: 206 ... By: Sean Bright (seanbright) 2019-03-08 10:52:23.573-0600 [~Stell0], just so that I am clear. Your {{identify}} block is _exactly_ this? {code} [206-identify] type=identify endpoint=206 {code} If so, I can understand why it is not working as it doesn't have any {{match}} or {{match_header}} directives. By: Sean Bright (seanbright) 2019-03-08 11:04:22.082-0600 Actually, I think the commit that changed things for you is [this one|https://gerrit.asterisk.org/c/asterisk/+/7844]: {noformat} res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation. The ip_identify_apply() did not validate the configuration for simple static configuration errors or deal well with address resolution errors. * Added missing configuration validation checks. * Fixed address resolution error handling. * Demoted an error message to a warning since it does not fail applying the identify object configuration. {noformat} So before this patch, your {{identify}} without any match directives still loaded, and now it is not loading. Does that jive with what you are seeing? By: Stefano Fancello (Stell0) 2019-03-11 04:40:06.799-0500 Yes, that's right. By: Sean Bright (seanbright) 2019-03-11 07:55:51.593-0500 [~Stell0], this does not appear to be a bug. The bug here is that before Asterisk 13.23, {{type = identify}} sections without any matching criteria were still loaded. Now that that bug has been resolved, they are failing to load and you should see that in your Asterisk logs. By: Stefano Fancello (Stell0) 2019-03-11 09:22:57.694-0500 Ok, thank you By: Asterisk Team (asteriskteam) 2019-03-11 09:22:57.992-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable.