| Summary: | ASTERISK-28388: Endpoint sync causes device unreach when a new contact is added | ||||
| Reporter: | Jason Hord (jhord) | Labels: | patch | ||
| Date Opened: | 2019-04-18 08:33:57 | Date Closed: | 2019-05-02 12:00:01 | ||
| Priority: | Major | Regression? | |||
| Status: | Closed/Complete | Components: | Resources/res_pjsip | ||
| Versions: | 16.3.0 | Frequency of Occurrence | Constant | ||
| Related Issues: |
| ||||
| Environment: | Attachments: | ( 0) asterisk-16.3.0-sync-endpoint.diff ( 1) full | |||
| Description: | I am seeing unrelated endpoints being set to unavailable when a contact is added to a completely different endpoint. As best I can tell from the code this is because an endpoint sync happens when the contact is added. This causes an AOR search which marks every other endpoint as unreachable. The unrelated endpoints are skipped which means the task_data structure is never initialized properly. After the loop exits, a check is made to see if an endpoint compositor was found and if not, the endpoint is marked offline. In my scenario, I can't see how the task_data structure would ever be valid for endpoints that match the filter criteria. | ||||
| Comments: | By: Asterisk Team (asteriskteam) 2019-04-18 08:33:58.044-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Jason Hord (jhord) 2019-04-18 08:39:01.595-0500 I have included a patch which fixes this issue for me. I have no idea if this even close to the correct solution. I've also included a full log which shows the reported issue. When endpoint 111-Nihil comes online, it knocks multiple other endpoints offline. This includes endpoint 555-Nihil which is a completely separate device on a completely separate AOR that was valid at the time. By: Joshua C. Colp (jcolp) 2019-04-18 09:00:14.932-0500 Do you plan on putting this up for review? And are ASTERISK-28056 the same underlying issue? By: Asterisk Team (asteriskteam) 2019-05-02 12:00:00.984-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines | ||||