| Summary: | ASTERISK-28419: app_amd: Does not work with silence suppression | ||
| Reporter: | Nasir Iqbal (nasir) | Labels: | patch |
| Date Opened: | 2019-05-17 20:22:16 | Date Closed: | 2019-06-27 11:35:38 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_amd |
| Versions: | 13.26.0 GIT | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | CentOs 7, All | Attachments: | ( 0) app_amd.diff |
| Description: | Referring to ticket ASTERISK-27610, Timeout during AMD detection i.e TOOLONG issue was fixed by using manual wait time instead of `framelength` for all none AST_FRAME_VOICE frames, further app_amd patched to ignore `AST_FRAME_NULL` at all
Now AMD detection algorithm bypassed when there is active voice suppression / AST_FRAME_NULL I think in case of AST_FRAME_NULL using manual wait time instead of `framelength` is enough to fix timeout / TOOLONG issue. and there is no need to ignore AST_FRAME_NULL | ||
| Comments: | By: Asterisk Team (asteriskteam) 2019-05-17 20:22:17.169-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Joshua C. Colp (jcolp) 2019-05-20 09:36:01.384-0500 Do you plan on putting this through code review? By: Nasir Iqbal (nasir) 2019-05-21 02:05:10.543-0500 patch submitted for code review at Gerrit against branch 13 https://gerrit.asterisk.org/c/asterisk/+/11394 By: Nasir Iqbal (nasir) 2019-05-21 23:50:54.301-0500 Ticket re-assigned back to me, Am I supposed to do something ? By: Joshua C. Colp (jcolp) 2019-05-22 05:58:34.730-0500 It's back to you because you have put a review up with code, and thus you own this currently since you're fixing it. By: Friendly Automation (friendly-automation) 2019-06-27 11:35:40.290-0500 Change 11488 merged by Kevin Harwell: app_amd: issue with silence suppression fixed [https://gerrit.asterisk.org/c/asterisk/+/11488|https://gerrit.asterisk.org/c/asterisk/+/11488] By: Friendly Automation (friendly-automation) 2019-06-27 11:35:55.740-0500 Change 11394 merged by Kevin Harwell: app_amd: issue with silence suppression fixed [https://gerrit.asterisk.org/c/asterisk/+/11394|https://gerrit.asterisk.org/c/asterisk/+/11394] By: Friendly Automation (friendly-automation) 2019-06-27 11:36:07.516-0500 Change 11487 merged by Kevin Harwell: app_amd: issue with silence suppression fixed [https://gerrit.asterisk.org/c/asterisk/+/11487|https://gerrit.asterisk.org/c/asterisk/+/11487] | ||