Summary:	ASTERISK-28448: chan_sip: Sometimes G729 (without annexb=no) is negotiated
Reporter:	jim thom (jimthom)	Labels:	fax
Date Opened:	2019-06-12 16:51:17	Date Closed:	2019-06-17 05:48:05
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Channels/chan_sip/CodecHandling
Versions:	16.4.0	Frequency of Occurrence
Related Issues:
Environment:	asterisk 16.4.0 Yealink G729 -> asterisk -> Cisco ENSR3.0.6	Attachments:
Description:	I noticed this issue when attempting to pass through G729 from a yealink to an upstream trunk using Cisco ENSR. Asterisk was sometimes allowing VAD to be enabled, which is not supported as this is part of G729 ANNEX B. Call was made from yealink to cisco via asterisk. There was no annexb=no being sent. I tried this patch and the problem went away. <removed inline patch>
Comments:	By: Asterisk Team (asteriskteam) 2019-06-12 16:51:18.171-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Joshua C. Colp (jcolp) 2019-06-17 05:06:21.719-0500 Is the res_format_attr_g729 module loaded? It is what is supposed to place this into the SDP. By: jim thom (jimthom) 2019-06-17 05:47:24.728-0500 No, that isn't loaded. It wasn't being built.  I think thatt my third party codec doesn't support annexb either. These were the options used to build: menuselect --enable chan_mobile --enable format_g729 --enable func_md5 \                                --disable app_adsiprog --disable app_alarmreceiver --disable app_chanspy --disable res_adsi --disable res_ael_share --disable res_stun_monitor \                                --disable res_convert --disable res_curl --disable app_db --disable app_directory --disable app_dictate --disable res_phoneprov \                                --disable chan_iax2 --disable chan_misdn --disable chan_nbs --disable chan_oss --disable chan_skinny --disable chan_unistim --disable res_limit  \                                --disable func_curl --disable func_devstate --disable func_odbc --disable func_realtime --disable cdr_csv --disable cdr_sqlite3_custom \                                --disable res_config_curl --disable app_agent_pool --disable res_hep_rtcp --disable app_getcpeid --disable app_image --disable app_ices --disable app_forkcdr \                                --disable pbx_dundi --disable pbx_realtime --disable format_g726 --disable format_h263 --disable format_h264 --disable format_gsm --disable format_g719 \                                --disable format_vox --disable format_pcm --disable format_siren7 --disable res_format_attr_g729 --disable res_format_attr_ilbc --disable res_format_attr_siren14 \                                --disable res_fax --disable cdr_custom --disable cel_custom --disable func_volume \                                --disable format_ogg_vorbis --disable format_wav_gsm --disable codec_dahdi --disable codec_lpc10 --disable codec_speex --disable codec_ilbc --disable codec_gsm \                                --disable codec_g722 --disable codec_g726 --disable codec_speex --disable chan_mgcp --disable chan_console --disable res_config_sqlite3 --disable res_sorcery_realtime\                                --disable app_osplookup --disable app_morsecode --disable app_mp3 --disable app_milliwatt --disable app_ices --disable res_sorcery_memory --disable res_format_attr_opus \                                --disable app_disa --disable app_dictate --disable app_ices --disable app_dahdiras --disable res_sorcery_astdb --disable res_sorcery_config --disable res_statsd \                                --disable app_fax --disable format_g723 --disable format_g726 --disable format_ilbc --disable res_hep --disable cel_sqlite3_custom --disable cel_manager \                                --disable res_security_log --disable res_realtime --disable app_meetme --disable func_sorcery --disable res_sorcery_memory_cache --disable res_rtp_multicast \                                --disable res_http_websocket --disable res_ari --disable res_format_attr_celt --disable res_format_attr_h263 --disable res_format_attr_h264 --disable res_format_attr_silk \                                --disable res_format_attr_siren7 --disable res_format_attr_vp8 --disable pbx_loopback --disable func_sorcery --disable func_pitchshift --disable func_cdr --disable func_aes \                                --disable app_url --disable app_test --disable app_talkdetect --disable app_festival --disable app_externalivr --disable app_echo --disable app_cdr --disable cdr_manager \                                --disable res_smdi --disable res_calendar --disable app_amd --disable app_queue --disable app_minivm --disable app_followme