Summary:	ASTERISK-28458: res_pjsip_sdp_rtp: Remove unused variable
Reporter:	Michael Maier (micha)	Labels:	patch pjsip
Date Opened:	2019-06-23 08:00:21	Date Closed:	2019-07-02 08:23:24
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_pjsip_sdp_rtp
Versions:	16.4.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:	( 0) sdp.patch
Description:	See attached patch.
Comments:	By: Asterisk Team (asteriskteam) 2019-06-23 08:00:23.818-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Michael Maier (micha) 2019-06-23 08:01:21.020-0500 The variable is unused. By: Joshua C. Colp (jcolp) 2019-06-24 05:43:42.384-0500 In the future please mark changes as contributions so they are properly managed in regard to licensing, regardless of the size. If you don't wish to sign the license agreement then just stating in normal English the variable is also fine. Is signing the license and putting it up for review on Gerrit something you would like to do? By: Michael Maier (micha) 2019-06-24 12:58:43.164-0500 I really appreciate your kind support - please don't misunderstand me! But I don't know what you want me to do exactly here: "If you don't wish to sign the license agreement then just stating in normal English the variable is also fine." Which string exactly do you expect to be written? I don't want to sign the license agreement, because I don't want to provide any personal data. You can use this patch if you want and if it works for you - or you may not use it - it's up to you. I've no problem with the license itself. If I would have any problem with you (or others) using it (on your own risk) whatever I posted, I wouldn't have posted them at all. By: Joshua C. Colp (jcolp) 2019-06-24 13:14:37.557-0500 I had to mark the patch as a code contribution as it was, and without a license it is therefore inaccessible. I was referring to stating in English what it accomplished: "variable X in function Y in file res_pjsip_sdp_rtp.c is unused" is perfectly fine. By: Michael Maier (micha) 2019-06-29 07:45:21.094-0500 Variable endpoint_caps in function set_caps in file res_pjsip_sdp_rtp.c is unused. By: Friendly Automation (friendly-automation) 2019-07-02 08:23:25.620-0500 Change 11511 merged by Joshua Colp: res_pjsip_sdp_rtp: Remove unused variable [https://gerrit.asterisk.org/c/asterisk/+/11511|https://gerrit.asterisk.org/c/asterisk/+/11511] By: Friendly Automation (friendly-automation) 2019-07-02 08:27:15.930-0500 Change 11510 merged by Friendly Automation: res_pjsip_sdp_rtp: Remove unused variable [https://gerrit.asterisk.org/c/asterisk/+/11510|https://gerrit.asterisk.org/c/asterisk/+/11510]