Summary:	ASTERISK-28488: pjsip mwi: n+1 sip notify's sent on re-register
Reporter:	Chris Savinovich (csavinovich)	Labels:	pjsip
Date Opened:	2019-07-26 16:37:01	Date Closed:	2019-08-30 09:59:16
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	.Release/Targets
Versions:	16.0.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	When _mw_subscribe_replaces_unsolicited_ is set on an endpoint then every time the phone re-registers Asterisk will send n + 1 SIP NOTIFY's to the phone (where n = number of notifies sent on the last re-register). Meaning at first Asterisk sends one notify. On the next register it sends two, then three, etc... Eventually the phone is overwhelmed. I was able to reproduce the issue just using Asterisk, and the following configuration {noformat} [414] type=aor mailboxes=414@default max_contacts=1 remove_existing=yes maximum_expiration=7200 minimum_expiration=60 qualify_frequency=60 [414-auth] type=auth auth_type=userpass password=414 username=414 [414] type=endpoint aors=414 auth=414-auth tos_audio=ef tos_video=af41 cos_audio=5 cos_video=4 allow=ulaw,alaw,gsm,g726,g722 context=from-internal callerid=Jean wifi <414> dtmf_mode=rfc4733 mailboxes=414@default mwi_subscribe_replaces_unsolicited=yes aggregate_mwi=no use_avpf=no rtcp_mux=no bundle=no ice_support=no media_use_received_transport=no trust_id_inbound=yes media_encryption=no timers=yes media_encryption_optimistic=no send_pai=yes rtp_symmetric=yes rewrite_contact=yes force_rport=yes language=en one_touch_recording=on record_on_feature=apprecord record_off_feature=apprecord set_var=CHANNEL(parkinglot)=default {noformat} Configure a phone to register to that extension, and on each register the notifies will increase. Comment out/disable _mw_subscribe_replaces_unsolicited_ and the problem goes away.
Comments:	By: Alexei Gradinari (alexei gradinari) 2019-07-29 09:56:47.285-0500 Need to say that it only happens if aggregate_mwi=false, by default it's 'true' By: Friendly Automation (friendly-automation) 2019-08-30 09:59:17.358-0500 Change 12794 merged by Friendly Automation: res_pjsip_mwi: add better handling of solicited vs unsolicited subscriptions [https://gerrit.asterisk.org/c/asterisk/+/12794|https://gerrit.asterisk.org/c/asterisk/+/12794] By: Friendly Automation (friendly-automation) 2019-09-03 05:36:46.973-0500 Change 12791 merged by George Joseph: res_pjsip_mwi: add better handling of solicited vs unsolicited subscriptions [https://gerrit.asterisk.org/c/asterisk/+/12791|https://gerrit.asterisk.org/c/asterisk/+/12791] By: Friendly Automation (friendly-automation) 2019-09-03 05:37:10.467-0500 Change 12790 merged by George Joseph: res_pjsip_mwi: add better handling of solicited vs unsolicited subscriptions [https://gerrit.asterisk.org/c/asterisk/+/12790|https://gerrit.asterisk.org/c/asterisk/+/12790] By: Friendly Automation (friendly-automation) 2019-09-03 05:37:32.561-0500 Change 12792 merged by George Joseph: res_pjsip_mwi: add better handling of solicited vs unsolicited subscriptions [https://gerrit.asterisk.org/c/asterisk/+/12792|https://gerrit.asterisk.org/c/asterisk/+/12792] By: Friendly Automation (friendly-automation) 2019-09-03 05:39:51.648-0500 Change 12793 merged by George Joseph: res_pjsip_mwi: add better handling of solicited vs unsolicited subscriptions [https://gerrit.asterisk.org/c/asterisk/+/12793|https://gerrit.asterisk.org/c/asterisk/+/12793]