[Home]

Summary:ASTERISK-28511: codec_resample: Bad sound quality when up sampling from SLIN16 to SLIN32
Reporter:Ruddy G (ruddy)Labels:
Date Opened:2019-08-21 11:28:05Date Closed:2019-08-30 07:47:06
Priority:MinorRegression?
Status:Closed/CompleteComponents:Codecs/codec_resample
Versions:13.28.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 162362.117-in.sln16
( 1) audacity-162362.117-in.wav
( 2) compare-outputs.png
( 3) output.sln32
Description:When asterisk receive a SIP call in SLIN16 codec and have to convert it to SLIN32, there is a degradation of sound quality at the places where we have voice saturation.

There is a sign inversion which creates a bad voice quality.

The same issue is present when converting a SLIN16 to SLIN32 format from the CLI interface.

Please see audio files in attachment as well as the screenshot.

Such issue is not present when we upsample the same file from another tool such as Audacity.
Comments:By: Asterisk Team (asteriskteam) 2019-08-21 11:28:05.828-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

By: Ruddy G (ruddy) 2019-08-21 11:40:38.781-0500

162362.117-in.sln16 is an original audio file recorded in SLN16 format.

output.sln32 is the conversion of 162362.117-in.sln16 in tho SLN32 by Asterisk. (file convert 162362.117-in.sln16 output.sln32)

audacity-162362.117-in.wav is the conversion of 162362.117-in.sln16 to 32kHz using Audacity.

compare-outputs.png is the comparaison between asterisk conversion and audacity conversion

By: Friendly Automation (friendly-automation) 2019-08-30 07:47:08.615-0500

Change 12786 merged by George Joseph:
codec_resample: Upgrade speex_resample to fix up-sampling bug

[https://gerrit.asterisk.org/c/asterisk/+/12786|https://gerrit.asterisk.org/c/asterisk/+/12786]

By: Friendly Automation (friendly-automation) 2019-08-30 07:48:10.134-0500

Change 12788 merged by George Joseph:
codec_resample: Upgrade speex_resample to fix up-sampling bug

[https://gerrit.asterisk.org/c/asterisk/+/12788|https://gerrit.asterisk.org/c/asterisk/+/12788]

By: Friendly Automation (friendly-automation) 2019-08-30 07:48:35.732-0500

Change 12787 merged by George Joseph:
codec_resample: Upgrade speex_resample to fix up-sampling bug

[https://gerrit.asterisk.org/c/asterisk/+/12787|https://gerrit.asterisk.org/c/asterisk/+/12787]

By: Friendly Automation (friendly-automation) 2019-08-30 07:50:12.189-0500

Change 12789 merged by George Joseph:
codec_resample: Upgrade speex_resample to fix up-sampling bug

[https://gerrit.asterisk.org/c/asterisk/+/12789|https://gerrit.asterisk.org/c/asterisk/+/12789]

By: Friendly Automation (friendly-automation) 2019-09-10 18:57:51.992-0500

Change 12850 merged by Friendly Automation:
codec_resample: Ensure OUTSIDE_SPEEX is defined when necessary

[https://gerrit.asterisk.org/c/asterisk/+/12850|https://gerrit.asterisk.org/c/asterisk/+/12850]

By: Friendly Automation (friendly-automation) 2019-09-11 06:21:59.386-0500

Change 12849 merged by Joshua Colp:
codec_resample: Ensure OUTSIDE_SPEEX is defined when necessary

[https://gerrit.asterisk.org/c/asterisk/+/12849|https://gerrit.asterisk.org/c/asterisk/+/12849]

By: Friendly Automation (friendly-automation) 2019-09-11 06:22:11.456-0500

Change 12852 merged by Joshua Colp:
codec_resample: Ensure OUTSIDE_SPEEX is defined when necessary

[https://gerrit.asterisk.org/c/asterisk/+/12852|https://gerrit.asterisk.org/c/asterisk/+/12852]

By: Friendly Automation (friendly-automation) 2019-09-11 06:22:21.788-0500

Change 12851 merged by Joshua Colp:
codec_resample: Ensure OUTSIDE_SPEEX is defined when necessary

[https://gerrit.asterisk.org/c/asterisk/+/12851|https://gerrit.asterisk.org/c/asterisk/+/12851]