Summary:	ASTERISK-28549: Two repeated 183
Reporter:	Gant Liu (Gant)	Labels:	pjsip
Date Opened:	2019-09-23 01:40:44	Date Closed:	2019-10-09 09:07:44
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Channels/chan_pjsip Resources/res_pjsip_session
Versions:	16.5.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) messages.log ( 1) two183.pcap
Description:	When endpoint A call to endpoint B, if the endpoint B response 183, the endpoint A will be received two repeated 183 response. I had found it is becasue in res/res_pjsip_session.c “session_inv_on_state_changed” and “session_inv_on_tsx_state_changed” all call the “handle_incoming_response”,one is AST_SIP_SESSION_BEFORE_MEDIA, another is AST_SIP_SESSION_AFTER_MEDIA, but in chan_pjsip.c they only has one callback “chan_pjsip_incoming_response”, so it will call “ast_queue_control(session->channel, AST_CONTROL_PROGRESS)” twice, so will get tow PROGRESS. Do we have a way to change this repetitive behavior?
Comments:	By: Asterisk Team (asteriskteam) 2019-09-23 01:40:45.413-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Joshua C. Colp (jcolp) 2019-09-23 04:32:54.801-0500 Unless there is an option, no there is no way. Per the community thread - what problem, besides stopping the second 183, are you trying to solve? By: Gant Liu (Gant) 2019-09-24 03:30:54.482-0500 I want to try to solve it, but I am afraid that my solution is not better. By: George Joseph (gjoseph) 2019-10-01 05:45:26.892-0500 Are you going to try and solve this yourself?  If not, we'll need more info about the issues this behavior is causing. By: Gant Liu (Gant) 2019-10-08 02:33:41.811-0500 If you can solve it, of course it is very well. Thanks for your attention. I have attach the log file and pcap file now. By: Benjamin Keith Ford (bford) 2019-10-08 08:15:13.708-0500 Just to reiterate what George said, can you explain what kind of problem this is causing? Is it breaking other functionality? We need a scenario that reproduces this behavior, and what problems it's causing. By: Gant Liu (Gant) 2019-10-08 21:03:37.472-0500 In most cases there is no problem. It's just that sometimes it creates incomprehensible puzzled and adds unnecessary overhead. By: Joshua C. Colp (jcolp) 2019-10-09 09:07:44.209-0500 As this is not presenting a problem and would be an improvement I'm closing this out for now. If you come up with a patch it can be attached and a comment will automatically reopen this. By: Friendly Automation (friendly-automation) 2021-01-11 11:35:19.045-0600 Change 15304 merged by Friendly Automation: chan_pjsip: Stop queueing control frames twice on outgoing channels [https://gerrit.asterisk.org/c/asterisk/+/15304|https://gerrit.asterisk.org/c/asterisk/+/15304] By: Friendly Automation (friendly-automation) 2021-01-11 12:16:58.607-0600 Change 15286 merged by Friendly Automation: chan_pjsip: Stop queueing control frames twice on outgoing channels [https://gerrit.asterisk.org/c/asterisk/+/15286|https://gerrit.asterisk.org/c/asterisk/+/15286] By: Friendly Automation (friendly-automation) 2021-01-11 12:48:10.975-0600 Change 15287 merged by George Joseph: chan_pjsip: Stop queueing control frames twice on outgoing channels [https://gerrit.asterisk.org/c/asterisk/+/15287|https://gerrit.asterisk.org/c/asterisk/+/15287]