Summary:	ASTERISK-28575: MWI Send Notify Crash on 16.6
Reporter:	Joshua Elson (joshelson)	Labels:	patch pjsip
Date Opened:	2019-10-09 15:29:38	Date Closed:	2019-10-15 14:11:24
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Resources/res_pjsip_mwi
Versions:	16.6.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) ASTERISK-28575.diff ( 1) asterisk-core-20191009-115321-brief.txt ( 2) asterisk-core-20191009-115321-full.txt ( 3) asterisk-core-20191009-115321-locks.txt ( 4) asterisk-core-20191009-115321-thread1.txt ( 5) pjsip_output.txt
Description:	New crash on 16.6 during attempt to send a notify message. We don't have a repro but this crash is very frequent on 16.6 and was not present before.
Comments:	By: Asterisk Team (asteriskteam) 2019-10-09 15:29:39.006-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Joshua Elson (joshelson) 2019-10-09 15:30:19.130-0500 Backtrace attached here. By: Kevin Harwell (kharwell) 2019-10-09 16:52:44.069-0500 This is happening when an endpoint registers and you've configured your endpoint for unsolicited MWI. Please attach your pjsip.conf configuration, or at the very least post an endpoint's configuration section along with any associated aor. Also are the associated mailboxes setup in voicemail.conf or somewhere else? By: Joshua Elson (joshelson) 2019-10-09 17:02:26.417-0500 We are using realtime for everything here, no static config files for endpoints or voicemail. We do send unsolicited MWI on registration. We use our custom ARI app for voicemail. In effect, it just updates the mailbox counts which triggers an MWI. By: Kevin Harwell (kharwell) 2019-10-09 17:11:46.804-0500 In that case CLI output might help. Could you post the output of the following: {noformat} *CLI> pjsip show endpoint <endpoint id> {noformat} {noformat} *CLI> pjsip show aor <aor id on associated endpoint id> {noformat} {noformat} *CLI> pjsip show contacts {noformat} Also just to verify, but it appears you are still using the astdb to store the contacts correct? By: Joshua Elson (joshelson) 2019-10-09 17:26:39.118-0500 Outputs of those three are attached here. Also, yes, we are still using astdb to store contacts. By: Kevin Harwell (kharwell) 2019-10-10 15:29:24.975-0500 [~joshelson] I've attached a patch ([^ASTERISK-28575.diff]). If you can please apply, and test it to make sure it fixes the issue. For some time frame that is, since your crash is intermittent. Thanks! By: Joshua Elson (joshelson) 2019-10-10 15:39:16.941-0500 Thanks a bunch. We'll deploy to some nodes and test it out. By: Friendly Automation (friendly-automation) 2019-10-14 10:21:18.646-0500 Change 13045 merged by Friendly Automation: res_pjsip_mwi: potential double unref, and potential unwanted double link [https://gerrit.asterisk.org/c/asterisk/+/13045|https://gerrit.asterisk.org/c/asterisk/+/13045] By: Kevin Harwell (kharwell) 2019-10-14 11:27:46.573-0500 [~joshelson], No news is good news? :-) I know it's only been a few days, but was wondering if you've come across any crashes again related to this issue with the patch installed? By: Friendly Automation (friendly-automation) 2019-10-14 12:03:47.139-0500 Change 13047 merged by George Joseph: res_pjsip_mwi: potential double unref, and potential unwanted double link [https://gerrit.asterisk.org/c/asterisk/+/13047|https://gerrit.asterisk.org/c/asterisk/+/13047] By: Friendly Automation (friendly-automation) 2019-10-14 12:04:00.668-0500 Change 13051 merged by George Joseph: res_pjsip_mwi: potential double unref, and potential unwanted double link [https://gerrit.asterisk.org/c/asterisk/+/13051|https://gerrit.asterisk.org/c/asterisk/+/13051] By: Friendly Automation (friendly-automation) 2019-10-14 12:04:22.913-0500 Change 13048 merged by George Joseph: res_pjsip_mwi: potential double unref, and potential unwanted double link [https://gerrit.asterisk.org/c/asterisk/+/13048|https://gerrit.asterisk.org/c/asterisk/+/13048] By: Friendly Automation (friendly-automation) 2019-10-14 12:47:52.969-0500 Change 13049 merged by Friendly Automation: res_pjsip_mwi: potential double unref, and potential unwanted double link [https://gerrit.asterisk.org/c/asterisk/+/13049|https://gerrit.asterisk.org/c/asterisk/+/13049] By: Friendly Automation (friendly-automation) 2019-10-14 12:57:24.215-0500 Change 13050 merged by Friendly Automation: res_pjsip_mwi: potential double unref, and potential unwanted double link [https://gerrit.asterisk.org/c/asterisk/+/13050|https://gerrit.asterisk.org/c/asterisk/+/13050] By: Friendly Automation (friendly-automation) 2019-10-14 13:35:52.716-0500 Change 13046 merged by George Joseph: res_pjsip_mwi: potential double unref, and potential unwanted double link [https://gerrit.asterisk.org/c/asterisk/+/13046|https://gerrit.asterisk.org/c/asterisk/+/13046] By: Kevin Harwell (kharwell) 2019-10-15 10:56:05.227-0500 [~joshelson] Any info/update on testing? Thanks! By: Joshua Elson (joshelson) 2019-10-15 12:14:53.681-0500 So far so good on our end. No observed crashes on this path. Looks like it's already committed here, but I think we're good to ship this. By: Asterisk Team (asteriskteam) 2019-10-15 12:14:54.026-0500 This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable. By: Kevin Harwell (kharwell) 2019-10-15 13:03:31.525-0500 [~joshelson] Really appreciate the testing and the feedback, thanks! Glad to hear the patch seems to have helped. This patch will be included in a regression release (16.6.1) we'll be doing soon.