Summary:	ASTERISK-28654: Enabling Real Time Text (RTT) for PJSIP library
Reporter:	Bharat Ramaswamy-Nandakumar (bharatram1)	Labels:
Date Opened:	2019-12-11 13:26:17.000-0600	Date Closed:
Priority:	Minor	Regression?
Status:	Waiting for Feedback/In Progress	Components:	Resources/res_pjsip_sdp_rtp
Versions:	16.0.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	I've been working on enabling Real time text for PJSIP library, I'm using t140 and t140red supported. I have fixed an issue where t140red was not working. I will be pushing my changes to a branch
Comments:	By: Asterisk Team (asteriskteam) 2019-12-11 13:26:18.349-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Bharat Ramaswamy-Nandakumar (bharatram1) 2019-12-13 19:43:12.796-0600 Hello, I've submitted the patch to gerrit, I would appreciate a review and feedback Thanks By: Christoph Rüdiger (christoph_tke) 2022-04-20 06:20:24.898-0500 Hello, I'm interested in seeing RTT on pjsip as well. Where can I find the patch? I didn't spot anything on gerrit.asterisk.org related to this issue. Thanks By: Joshua C. Colp (jcolp) 2022-04-20 06:28:22.261-0500 You can find the reviews by following: https://gerrit.asterisk.org/q/asterisk-28654 From looking at the history I had comments, and there was an open licensing question. By: Bharat Ramaswamy-Nandakumar (bharat@indigital.net) 2022-04-20 08:55:31.663-0500 Hey, The work was done for an internal project and I wanted to share it. I can go ahead and make my changes into the latest version of Asterisk and push it up By: Joshua C. Colp (jcolp) 2022-04-20 09:00:08.157-0500 Would you be taking care of the review comments, and clarifying the license agreement situation? By: Bharat Ramaswamy-Nandakumar (bharat@indigital.net) 2022-04-20 09:14:52.998-0500 Yeah, the others who worked on it do not want to take credit. By: Joshua C. Colp (jcolp) 2022-04-20 09:19:24.242-0500 It's not about credit. It's about ensuring that the code is clearly licensed for inclusion, which requires a license agreement from all authors. By: Bharat Ramaswamy-Nandakumar (bharat@indigital.net) 2022-04-20 12:42:37.726-0500 Yeah, I believe they have all agreed to the license By: Joshua C. Colp (jcolp) 2022-04-20 12:47:16.348-0500 I would need their JIRA usernames to check. By: Bharat Ramaswamy-Nandakumar (bharat@indigital.net) 2022-04-20 12:54:18.691-0500 codeMonkey85 is the only one. By: Corey Wysong (codeMonkey85) 2022-04-20 12:55:59.143-0500 I agree to the license. By: Joshua C. Colp (jcolp) 2022-04-20 13:04:17.927-0500 Yes, you have a valid license. What about "Seth Marks"? By: Bharat Ramaswamy-Nandakumar (bharat@indigital.net) 2022-04-20 13:11:46.232-0500 He gave us advice but did not actually contribute to any code By: Joshua C. Colp (jcolp) 2022-04-20 13:19:24.256-0500 Ok, then as part of updating it his name can remain but it needs to be stated he did not provide any code. By: Bharat Ramaswamy-Nandakumar (bharat@indigital.net) 2022-04-20 13:19:57.301-0500 Sounds good By: Jonathan Rose (JonathanRRose) 2022-09-08 18:19:13.744-0500 Hey Bharat, are you all still actively working on this? All I see right now is an abandoned review on Gerrit from last year. edit: correction, two years ago.