Summary:	ASTERISK-28660: res_fax: wrap Asterisk initiated negotiation with config option
Reporter:	Kevin Harwell (kharwell)	Labels:	fax
Date Opened:	2019-12-13 13:46:38.000-0600	Date Closed:	2020-01-02 08:39:42.000-0600
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Resources/res_fax
Versions:	13.29.1 16.6.1 17.0.1	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	A previous patch: Gerrit Change-Id: I73bb24799bfe1a48adae9c034a2edbae54cc2a39 Made it so a T.38 Gateway tries to negotiate with both sides by sending T.38 negotiation request to both endpoints supported T.38 versus the previous behavior of forwarding negotiation to the "other" channel once a preamble was detected. This had the unfortunate side effect of breaking some setups. Specifically ones that set the max datagram option on an endpoint configuration (configured max datagram was not propagated since Asterisk now initiates negotiations). Make it so this patched functionality is itself wrapped in an option, so the use case happens for it only in those setups requiring it.
Comments:	By: Kevin Harwell (kharwell) 2019-12-13 14:33:25.415-0600 [~alexei gradinari] Wasn't sure the best way for you to see this change, so pinging you here and added you as a reviewer on the review (https://gerrit.asterisk.org/c/asterisk/+/13443) Just wanted to make you aware we've had to wrap your previous res_fax patch in a configuration option. You'll need to set "negotiate_both" to "yes" now in order for your patch to send out both negotiation requests. Also any testing and/or feedback on the review you can give would be much appreciated. Thanks! By: Friendly Automation (friendly-automation) 2020-01-02 08:39:42.841-0600 Change 13431 merged by Friendly Automation: res_fax: wrap v21 detected Asterisk initiated negotiation with config option [https://gerrit.asterisk.org/c/asterisk/+/13431|https://gerrit.asterisk.org/c/asterisk/+/13431] By: Friendly Automation (friendly-automation) 2020-01-02 08:42:21.494-0600 Change 13443 merged by Friendly Automation: res_fax: wrap v21 detected Asterisk initiated negotiation with config option [https://gerrit.asterisk.org/c/asterisk/+/13443|https://gerrit.asterisk.org/c/asterisk/+/13443] By: Friendly Automation (friendly-automation) 2020-01-02 08:44:16.383-0600 Change 13432 merged by George Joseph: res_fax: wrap v21 detected Asterisk initiated negotiation with config option [https://gerrit.asterisk.org/c/asterisk/+/13432|https://gerrit.asterisk.org/c/asterisk/+/13432] By: Friendly Automation (friendly-automation) 2020-01-02 08:44:51.474-0600 Change 13430 merged by Joshua Colp: res_fax: wrap v21 detected Asterisk initiated negotiation with config option [https://gerrit.asterisk.org/c/asterisk/+/13430|https://gerrit.asterisk.org/c/asterisk/+/13430]