Summary:	ASTERISK-28667: Asterisk ignores parsing of config files if a Byte order mark is present
Reporter:	Robin Leffmann (robleff)	Labels:
Date Opened:	2019-12-18 13:40:38.000-0600	Date Closed:	2019-12-27 10:09:48.000-0600
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Configs/Basic-PBX
Versions:	16.5.1	Frequency of Occurrence	Constant
Related Issues:
Environment:	CentOS 7	Attachments:
Description:	If a Byte order mark ("BOM") is present in a .conf file, Asterisk will incorrectly state in the log that it has parsed the file but will in effect actually skip the file entirely, without throwing a warning or error. The BOM is a series of three bytes, 0xEF 0xBB 0xBF, represented by Unicode code point U+FEFF, and is typically located at the very start of a text file, and sometimes at the start of one or more lines in a text file. A test patch prodced and offered by [~seanbright] on IRC proved to solve the problem.
Comments:	By: Asterisk Team (asteriskteam) 2019-12-18 13:40:39.689-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Kevin Harwell (kharwell) 2019-12-18 18:30:48.240-0600 [~seanbright] Any thoughts on this, or do you still have the patch around to attach here or push up to gerrit - if so inclined of course :-) By: Sean Bright (seanbright) 2019-12-19 04:41:42.792-0600 [~kharwell], Yup, I'm on it. By: Kevin Harwell (kharwell) 2019-12-19 08:38:18.973-0600 [~seanbright] Many thanks! By: Friendly Automation (friendly-automation) 2019-12-27 10:09:49.884-0600 Change 13457 merged by Friendly Automation: config.c: Skip UTF-8 BOMs if present when reading config files [https://gerrit.asterisk.org/c/asterisk/+/13457|https://gerrit.asterisk.org/c/asterisk/+/13457] By: Friendly Automation (friendly-automation) 2019-12-27 13:12:55.506-0600 Change 13489 merged by George Joseph: config.c: Skip UTF-8 BOMs if present when reading config files [https://gerrit.asterisk.org/c/asterisk/+/13489|https://gerrit.asterisk.org/c/asterisk/+/13489] By: Friendly Automation (friendly-automation) 2019-12-27 13:13:21.014-0600 Change 13487 merged by George Joseph: config.c: Skip UTF-8 BOMs if present when reading config files [https://gerrit.asterisk.org/c/asterisk/+/13487|https://gerrit.asterisk.org/c/asterisk/+/13487] By: Friendly Automation (friendly-automation) 2019-12-27 13:13:40.518-0600 Change 13488 merged by George Joseph: config.c: Skip UTF-8 BOMs if present when reading config files [https://gerrit.asterisk.org/c/asterisk/+/13488|https://gerrit.asterisk.org/c/asterisk/+/13488]