Summary:	ASTERISK-28673: GET FULL VARIABLE documentation clarification
Reporter:	Jonathan Harris (lardconcepts)	Labels:
Date Opened:	2019-12-28 02:05:44.000-0600	Date Closed:	2020-01-07 09:11:31.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Documentation
Versions:	17.1.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	As per discussion on mailing list and clarified by Sean Bright, GET FULL VARIABLE documentation is missing the fact that the variable requires ${dollar_brace}, otherwise it just sends the variable name back. https://wiki.asterisk.org/wiki/display/AST/Asterisk+17+AGICommand_get+full+variable As requested, patch submitted at https://github.com/asterisk/asterisk/pull/17 Thank you for this great bit of software!
Comments:	By: Asterisk Team (asteriskteam) 2019-12-28 02:05:45.714-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Jonathan Harris (lardconcepts) 2020-01-02 15:52:44.437-0600 Not sure what to do with this - I submitted a patch to github as request on the list, but apparently it has to be done via Gerrit, which I gave up with after going around in increasingly frustrating "can't login even after password reset" circles. By: Joshua C. Colp (jcolp) 2020-01-02 15:57:40.294-0600 Have you signed the license agreement linked at the top of JIRA and waited for it to be accepted? If not, then we can't accept patches and you would not be able to log into Gerrit. By: Jonathan Harris (lardconcepts) 2020-01-02 16:01:10.627-0600 It shouldn't be this hard to make a simple documentation change - I've given up and just made a note at the foot of https://wiki.asterisk.org/wiki/display/AST/Asterisk+17+AGICommand_get+full+variable By: Sean Bright (seanbright) 2020-01-03 10:29:20.207-0600 Sorry for the difficulty you've been having, [~lardconcepts]. I've created a Gerrit review for this issue. By: Friendly Automation (friendly-automation) 2020-01-07 09:11:32.322-0600 Change 13509 merged by Friendly Automation: res_agi: Improve GET FULL VARIABLE documentation [https://gerrit.asterisk.org/c/asterisk/+/13509|https://gerrit.asterisk.org/c/asterisk/+/13509] By: Friendly Automation (friendly-automation) 2020-01-07 09:14:04.834-0600 Change 13542 merged by Friendly Automation: res_agi: Improve GET FULL VARIABLE documentation [https://gerrit.asterisk.org/c/asterisk/+/13542|https://gerrit.asterisk.org/c/asterisk/+/13542] By: Friendly Automation (friendly-automation) 2020-01-07 09:16:12.644-0600 Change 13543 merged by Friendly Automation: res_agi: Improve GET FULL VARIABLE documentation [https://gerrit.asterisk.org/c/asterisk/+/13543|https://gerrit.asterisk.org/c/asterisk/+/13543] By: Friendly Automation (friendly-automation) 2020-01-07 09:54:02.080-0600 Change 13544 merged by Friendly Automation: res_agi: Improve GET FULL VARIABLE documentation [https://gerrit.asterisk.org/c/asterisk/+/13544|https://gerrit.asterisk.org/c/asterisk/+/13544]