Summary:	ASTERISK-28738: Incorrect state machine used when MOH_PASSTHRU is used
Reporter:	Torrey Searle (tsearle)	Labels:
Date Opened:	2020-02-12 10:03:23.000-0600	Date Closed:	2020-02-18 10:09:04.000-0600
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	Resources/res_pjsip_sdp_rtp
Versions:	13.20.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:
Description:	When MOH_PASSTRHOUGH is active in a setup A -> ASTERISK -> B When A sends on-hold, asterisk sends an on-hold with "sendonly" to B However if while the first hold is active and B wants to hold in the reverse direction, B sends "inactive", but asterisk incorrectly forwards this to A as "sendonly" This is in violation of RFC3264 section 8.4 which says as follows:   If the stream to be placed on hold was previously a sendrecv media   stream, it is placed on hold by marking it as sendonly.  If the   stream to be placed on hold was previously a recvonly media stream,   it is placed on hold by marking it inactive. Attached is a patch and a testsuite test that validates the on hold state machine is properly implemented
Comments:	By: Asterisk Team (asteriskteam) 2020-02-12 10:03:24.181-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Friendly Automation (friendly-automation) 2020-02-18 10:09:07.761-0600 Change 13802 merged by George Joseph: res_pjsip_sdp_rtp: implement hold state handling on moh_passthrough [https://gerrit.asterisk.org/c/asterisk/+/13802|https://gerrit.asterisk.org/c/asterisk/+/13802] By: Friendly Automation (friendly-automation) 2020-02-18 10:09:34.194-0600 Change 13821 merged by George Joseph: res_pjsip_sdp_rtp: implement hold state handling on moh_passthrough [https://gerrit.asterisk.org/c/asterisk/+/13821|https://gerrit.asterisk.org/c/asterisk/+/13821] By: Friendly Automation (friendly-automation) 2020-02-18 10:10:04.208-0600 Change 13822 merged by George Joseph: res_pjsip_sdp_rtp: implement hold state handling on moh_passthrough [https://gerrit.asterisk.org/c/asterisk/+/13822|https://gerrit.asterisk.org/c/asterisk/+/13822] By: Friendly Automation (friendly-automation) 2020-02-18 10:10:29.358-0600 Change 13823 merged by George Joseph: res_pjsip_sdp_rtp: implement hold state handling on moh_passthrough [https://gerrit.asterisk.org/c/asterisk/+/13823|https://gerrit.asterisk.org/c/asterisk/+/13823]