Summary:	ASTERISK-28813: func_volume: Allow decimal numbers as parameter to improve granularity
Reporter:	Jean Aunis - Prescom (PrescomJA)	Labels:
Date Opened:	2020-04-07 05:06:48	Date Closed:	2020-04-14 09:29:29
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Functions/func_volume
Versions:	16.9.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	VOLUME function currently takes an integer as parameter, and multiplies (or divides) the audio frames volume by the provided value. In order to provide a finer grained volume control, I suggest modifying func_volume to accept a decimal number as parameter. Control DTMF '*' and '#' would still increase or reduce the volume by 1.
Comments:	By: Asterisk Team (asteriskteam) 2020-04-07 05:06:49.052-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: George Joseph (gjoseph) 2020-04-07 10:35:30.088-0500 Will you be submitting a patch to add the functionality? By: Jean Aunis - Prescom (PrescomJA) 2020-04-07 10:41:03.158-0500 Yes I'm preparing the patch. By: George Joseph (gjoseph) 2020-04-07 10:42:08.673-0500 Great, thanks! By: Friendly Automation (friendly-automation) 2020-04-14 09:29:30.533-0500 Change 14089 merged by Friendly Automation: func_volume: Accept decimal number as argument [https://gerrit.asterisk.org/c/asterisk/+/14089|https://gerrit.asterisk.org/c/asterisk/+/14089] By: Friendly Automation (friendly-automation) 2020-04-14 09:29:49.857-0500 Change 14174 merged by Friendly Automation: func_volume: Accept decimal number as argument [https://gerrit.asterisk.org/c/asterisk/+/14174|https://gerrit.asterisk.org/c/asterisk/+/14174] By: Friendly Automation (friendly-automation) 2020-04-14 09:31:06.396-0500 Change 14173 merged by Friendly Automation: func_volume: Accept decimal number as argument [https://gerrit.asterisk.org/c/asterisk/+/14173|https://gerrit.asterisk.org/c/asterisk/+/14173] By: Friendly Automation (friendly-automation) 2020-04-14 09:38:19.215-0500 Change 14172 merged by George Joseph: func_volume: Accept decimal number as argument [https://gerrit.asterisk.org/c/asterisk/+/14172|https://gerrit.asterisk.org/c/asterisk/+/14172]