[Home]

Summary:ASTERISK-28819: [patch] bridge_softmix_binaural: Show state in menuselect.
Reporter:Alexander Traud (traud)Labels:patch
Date Opened:2020-04-09 08:24:32Date Closed:2020-04-13 10:31:03
Priority:MinorRegression?
Status:Closed/CompleteComponents:Bridges/bridge_softmix
Versions:16.9.0 17.3.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) bridges_option_show.patch
Description:Via {{make menuselect}}, the user is able to de-select and select individual modules and options for modules. The option binaural_rendering_in_bridge_softmix can be enabled in the category Bridging Modules ({{MENUSELECT_BRIDGES}}). However, once enabled, the current state is not shown in the next {{make menuselect}}. Therefore, the option can only be de-selected by de-selecting the whole module bridge_softmix.

The cause for this was the very last patch-set (of 30) of [its code review|https://gerrit.asterisk.org/3524], see the attached patch, created by an Asterisk core team member. I have no idea, why that condition was added at all. I tested several cases and that condition seems simply wrong.
Comments:By: Asterisk Team (asteriskteam) 2020-04-09 08:24:33.763-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

By: Friendly Automation (friendly-automation) 2020-04-13 10:31:05.015-0500

Change 14167 merged by George Joseph:
bridge_softmix_binaural: Show state in menuselect.

[https://gerrit.asterisk.org/c/asterisk/+/14167|https://gerrit.asterisk.org/c/asterisk/+/14167]

By: Friendly Automation (friendly-automation) 2020-04-13 10:31:21.069-0500

Change 14168 merged by George Joseph:
bridge_softmix_binaural: Show state in menuselect.

[https://gerrit.asterisk.org/c/asterisk/+/14168|https://gerrit.asterisk.org/c/asterisk/+/14168]

By: Friendly Automation (friendly-automation) 2020-04-13 10:31:36.875-0500

Change 14146 merged by George Joseph:
bridge_softmix_binaural: Show state in menuselect.

[https://gerrit.asterisk.org/c/asterisk/+/14146|https://gerrit.asterisk.org/c/asterisk/+/14146]