Summary:	ASTERISK-28840: samples: Missing for the modules cdr_ and cel_sqlite3_custom.
Reporter:	Alexander Traud (traud)	Labels:	patch
Date Opened:	2020-04-16 05:29:25	Date Closed:
Priority:	Trivial	Regression?
Status:	Open/New	Components:	CDR/cdr_sqlite3_custom CEL/cel_sqlite3_custom Configs/Samples
Versions:	16.9.0 17.3.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) loader.patch ( 1) sqlite3_custom.patch
Description:	On a minimal installation, after doing {{sudo make install config samples}} Asterisk gives: {code} WARNING: loader.c: load_modules: Some non-required modules failed to load. ERROR: loader.c: load_modules: cdr_sqlite3_custom declined to load. ERROR: loader.c: load_modules: cel_sqlite3_custom declined to load. Asterisk Ready. {code} I know that those ‘errors’ are trivial. However, a default, minimal installation cannot give errors. This confuses (a lot of) users, they cannot analyze/fix it themselves, and points them to the wrong cause for their actual issues. Therefore such wrong error message are expensive, especially in support.
Comments:	By: Asterisk Team (asteriskteam) 2020-04-16 05:29:26.321-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: George Joseph (gjoseph) 2020-04-16 08:17:08.916-0500 Are you going to be fixing this one? By: Alexander Traud (traud) 2020-04-17 04:02:05.898-0500 Not determined, yet. Therefore, I have reported it. I found the same issue in parallel with the mentioned reports, so it is reproduced. I looked into it and the cause is a wrong/missing sample file. I still have to figure out what exactly is expected in the sample file. If that is not feasible for a sample configuration, my next idea is to lower the message to notice. A standard minimal installation cannot give a warning either. By: George Joseph (gjoseph) 2020-04-17 08:15:22.271-0500 Fair enough.  I'm going to acknowledge the issue and assign it to you.  If you decide not to work it, just send it back to triage. By: Alexander Traud (traud) 2020-04-19 07:14:14.681-0500 {code} cdr/cdr_sqlite3_custom.c ↳ load_module()  ↳ load_config(0)    ↳ if (!ast_variable_browse(cfg, "master")) { {code} That fails. There is a section ‘master’ in the file {{cdr_sqlite3_custom.conf.sample}} but that section is empty. I am not sure how to proceed from here. One trick (see the attached patch) would be to return not -1, not 0 but 1. Then, {{load_module}} could state: If the configuration file is empty, I do not proceed but load at least. However, then what about the subsequent code, is that executed in case of a reload: Some SQL statements and the module registering with its backend? That was CDR. Same for CEL. As this is over my head, I have to leave the issue to someone else. 2. The next alternative, or a thing which should be done as well, would be to lower the log level of the loader itself, see the other attached patch. 3. The next alternative would be not to load those two via {{modules.conf.sample}} like it was done with {{res_hep_rtcp}}. By: Alexander Traud (traud) 2020-04-19 07:14:31.941-0500 Can I change the state to Triage myself? Can I remove my assignment myself? Looks like, I do not have the button(s) for this. By: Joshua C. Colp (jcolp) 2020-04-19 08:24:32.188-0500 I have placed the issue back into triage.