Summary:	ASTERISK-28866: third-party/pjproject/configure.m4 contains bashisms
Reporter:	Guido Falsi (madpilot)	Labels:
Date Opened:	2020-05-03 05:22:24	Date Closed:	2020-05-05 09:25:11
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Third-Party/pjproject
Versions:	13.33.0 16.10.0 17.4.0	Frequency of Occurrence
Related Issues:
Environment:	FreeBSD, no bash shell installed	Attachments:
Description:	Fellow FreeBSD developer cmt@FreeBSD.org reported that asterisk configure script contains shell constructs supported only by bash. I tracked it down to += syntax for strings used in third-party/pjproject/configure.m4 I'm going to file a proposed fix in gerrit, allowing configure script to work in any plain Bourne shell. Many older versions are affected, I only listed current versions in the field.
Comments:	By: Asterisk Team (asteriskteam) 2020-05-03 05:22:26.068-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Friendly Automation (friendly-automation) 2020-05-05 09:25:12.928-0500 Change 14336 merged by Joshua Colp: pjproject: Remove bashism from configure.m4 script [https://gerrit.asterisk.org/c/asterisk/+/14336|https://gerrit.asterisk.org/c/asterisk/+/14336] By: Friendly Automation (friendly-automation) 2020-05-05 09:27:31.502-0500 Change 14379 merged by Friendly Automation: pjproject: Remove bashism from configure.m4 script [https://gerrit.asterisk.org/c/asterisk/+/14379|https://gerrit.asterisk.org/c/asterisk/+/14379] By: Friendly Automation (friendly-automation) 2020-05-05 09:29:33.954-0500 Change 14380 merged by Joshua Colp: pjproject: Remove bashism from configure.m4 script [https://gerrit.asterisk.org/c/asterisk/+/14380|https://gerrit.asterisk.org/c/asterisk/+/14380] By: Friendly Automation (friendly-automation) 2020-05-05 09:30:34.880-0500 Change 14378 merged by Joshua Colp: pjproject: Remove bashism from configure.m4 script [https://gerrit.asterisk.org/c/asterisk/+/14378|https://gerrit.asterisk.org/c/asterisk/+/14378]