Summary:	ASTERISK-28974: res_rtp_asterisk: T.140 messages have appended RTP string to each message block.
Reporter:	Thomas Johnson (tom5870)	Labels:
Date Opened:	2020-07-02 13:34:28	Date Closed:	2020-08-25 09:35:49
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Resources/res_rtp_asterisk
Versions:	13.23.0 16.7.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	CentOS 7	Attachments:	( 0) rtt_filt.pcapng
Description:	I am sure this effects all versions 13-17.   But when Asterisk sends T.140 messages or packets the messages in RED format, it appends an RTP\0 to each message block. If you are unsure about how to do this, SipCon1 and make sure use insecure=invite in your SIP configuration since SipCon1 does not support authenticed invites.
Comments:	By: Asterisk Team (asteriskteam) 2020-07-02 13:34:30.435-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: Joshua C. Colp (jcolp) 2020-07-06 04:28:23.230-0500 Do you have a packet capture showing this issue that can be provided publicly for anyone interested in looking into this issue for more easily reproducing? By: Thomas Johnson (tom5870) 2020-07-06 07:26:35.964-0500 Here is the packet trace.   172.25.54.194 is IP address of the Asterisk switch 172.25.53.18 was the caller and 172.25.54.43 answered the call.  Wasn't sure how much you wanted so this is all SIP and RTP.   I generally use rtp.p_type!=0 as filter to just see the T.140 packets. By: Thomas Johnson (tom5870) 2020-07-21 13:06:12.329-0500 Is there a chance this will be looked at in the next couple of months?   Not expecting a response given the above, but my management is just asking me to. By: Joshua C. Colp (jcolp) 2020-07-21 13:09:14.641-0500 As Asterisk is an open source project there is no time guarantees or any idea of when someone may choose to look at this. By: Friendly Automation (friendly-automation) 2020-08-25 09:35:50.961-0500 Change 14736 merged by Friendly Automation: bridge_channel: Ensure text messages are zero terminated [https://gerrit.asterisk.org/c/asterisk/+/14736|https://gerrit.asterisk.org/c/asterisk/+/14736] By: Friendly Automation (friendly-automation) 2020-08-25 10:08:19.635-0500 Change 14772 merged by Friendly Automation: bridge_channel: Ensure text messages are zero terminated [https://gerrit.asterisk.org/c/asterisk/+/14772|https://gerrit.asterisk.org/c/asterisk/+/14772] By: Friendly Automation (friendly-automation) 2020-08-25 10:13:47.310-0500 Change 14773 merged by Friendly Automation: bridge_channel: Ensure text messages are zero terminated [https://gerrit.asterisk.org/c/asterisk/+/14773|https://gerrit.asterisk.org/c/asterisk/+/14773] By: Friendly Automation (friendly-automation) 2020-08-25 10:26:20.359-0500 Change 14775 merged by Friendly Automation: bridge_channel: Ensure text messages are zero terminated [https://gerrit.asterisk.org/c/asterisk/+/14775|https://gerrit.asterisk.org/c/asterisk/+/14775] By: Friendly Automation (friendly-automation) 2020-08-25 10:28:16.319-0500 Change 14774 merged by Friendly Automation: bridge_channel: Ensure text messages are zero terminated [https://gerrit.asterisk.org/c/asterisk/+/14774|https://gerrit.asterisk.org/c/asterisk/+/14774]