| Summary: | ASTERISK-29008: Adding an XMPP component user does not approve subscription | ||
| Reporter: | Stephen Paul Weber (singpolyma) | Labels: | |
| Date Opened: | 2020-07-23 20:38:08 | Date Closed: | 2020-08-07 12:00:01 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Resources/res_xmpp |
| Versions: | GIT | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | debian stable | Attachments: | |
| Description: | If you set res_xmpp to connect as a component at host `asterisk`, and then from an XMPP client you add a new contact `someone@asterisk` you will find that res_xmpp sends presence (so you know the user is "online") but does *not* approve the subscription.
Looking at the code in `xmpp_pak_s10n` one can see that the `subscribed` response is *always* send from the jid of the component no matter what is being subscribed to, while presence is correctly sent back from the jid being subscribed to. {code:none} diff --git a/res/res_xmpp.c b/res/res_xmpp.c index 0f304375fe..e821babe80 100644 --- a/res/res_xmpp.c +++ b/res/res_xmpp.c @@ -3401,7 +3401,7 @@ static int xmpp_pak_s10n(struct ast_xmpp_client *client, struct ast_xmpp_client_ if ((presence = iks_new("presence")) && (status = iks_new("status"))) { iks_insert_attrib(presence, "type", "subscribed"); iks_insert_attrib(presence, "to", pak->from->full); - iks_insert_attrib(presence, "from", client->jid->full); + iks_insert_attrib(presence, "from", pak->from->full); if (pak->id) { iks_insert_attrib(presence, "id", pak->id); {code} | ||
| Comments: | By: Asterisk Team (asteriskteam) 2020-07-23 20:38:11.055-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. By: George Joseph (gjoseph) 2020-07-24 10:28:26.353-0500 Since you already seem to know what the issue is and how to correct it, can you submit a patch to Gerrit? https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process By: Asterisk Team (asteriskteam) 2020-08-07 12:00:00.931-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines | ||