[Home]

Summary:ASTERISK-29021: [patch] Fix VERSION(ASTERISK_VERSION_NUM) on certified versions
Reporter:cmaj (cmaj)Labels:
Date Opened:2020-08-06 12:48:08Date Closed:2020-08-14 14:46:24
Priority:MinorRegression?
Status:Closed/CompleteComponents:Functions/func_version
Versions:16.8.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The output of ${VERSION(ASTERISK_VERSION_NUM)} normally produces an integer of 6 digits, eg. Asterisk 16.8.0 produces 160800.

There is corner case for git/svn pulls that should produce 999999, which makes sense (although 169999, 179999, 189999, etc. might make more sense.)

Anyhow, certified versions fail to parse in reasonable manner; eg. Asterisk certified version 16.3-cert1 produces 00300, while both Asterisk certified versions 16.8-cert2 and 16.8-cert3 produce the same number 00800. This prevents dial plans from making adjustments on-the-fly to support earlier or later versions of Asterisk using different call flows.

Pending patch adds a sed pipe before awk in Makefile to produce output like 160301, 160802, 160803, etc. The trade-off is potential conflict with non-certified versions if naming is not carefully considered, but none of the certified version 16's released so far would cause this problem because the naming is already being carefully considered (there is no 16.3.1, 16.8.2, or 16.8.3 in the non-certified releases.)
Comments:By: Asterisk Team (asteriskteam) 2020-08-06 12:48:09.114-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.
By: Friendly Automation (friendly-automation) 2020-08-14 14:46:25.495-0500

Change 14749 merged by Friendly Automation:
Makefile: Fix certified version numbers

[https://gerrit.asterisk.org/c/asterisk/+/14749|https://gerrit.asterisk.org/c/asterisk/+/14749]
By: Friendly Automation (friendly-automation) 2020-08-14 14:50:02.322-0500

Change 14751 merged by Friendly Automation:
Makefile: Fix certified version numbers

[https://gerrit.asterisk.org/c/asterisk/+/14751|https://gerrit.asterisk.org/c/asterisk/+/14751]
By: Friendly Automation (friendly-automation) 2020-08-14 14:51:26.099-0500

Change 14724 merged by Friendly Automation:
Makefile: Fix certified version numbers

[https://gerrit.asterisk.org/c/asterisk/+/14724|https://gerrit.asterisk.org/c/asterisk/+/14724]
By: Friendly Automation (friendly-automation) 2020-08-14 14:53:33.816-0500

Change 14750 merged by Friendly Automation:
Makefile: Fix certified version numbers

[https://gerrit.asterisk.org/c/asterisk/+/14750|https://gerrit.asterisk.org/c/asterisk/+/14750]
By: Friendly Automation (friendly-automation) 2020-08-14 15:20:40.954-0500

Change 14748 merged by Kevin Harwell:
Makefile: Fix certified version numbers

[https://gerrit.asterisk.org/c/asterisk/+/14748|https://gerrit.asterisk.org/c/asterisk/+/14748]