[Home]

Summary:ASTERISK-29161: Incorrect setup of recall channels
Reporter:Boris P. Korzun (drtr0jan)Labels:patch
Date Opened:2020-11-12 13:20:26.000-0600Date Closed:2020-11-18 10:14:27.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Bridges/bridge_simple
Versions:13.37.0 16.14.1 18.0.1 Frequency of
Occurrence		Constant
Related
Issues:
Environment:FreeBSD 12.2, Asterisk 18.0.1Attachments:( 0) bridge_basic.c.diff
Description:There's a bug (like a typo) in retransfer_enter() at main/bridge_basic.c:2641.
common_recall_channel_setup() setups common things on the recalled transfer target, but uses same target as source instead trasfered.

{{common_recall_channel_setup(props->recall_target, props->recall_target);}}

But it should be like:
{{common_recall_channel_setup(props->recall_target, props->transferer);}}
Comments:By: Asterisk Team (asteriskteam) 2020-11-12 13:20:27.147-0600

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].
By: Sean Bright (seanbright) 2020-11-12 15:37:14.266-0600

[~drtr0jan], your patch appears to be correct - will you be [submitting it to Gerrit for review and inclusion|https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage]?
By: Boris P. Korzun (drtr0jan) 2020-11-13 06:37:08.081-0600

[~seanbright], ok, I've submitted it to Gerrit.
By: Friendly Automation (friendly-automation) 2020-11-18 10:14:28.822-0600

Change 15182 merged by George Joseph:
bridge_basic: Fixed setup of recall channels

[https://gerrit.asterisk.org/c/asterisk/+/15182|https://gerrit.asterisk.org/c/asterisk/+/15182]
By: Friendly Automation (friendly-automation) 2020-11-18 10:14:39.984-0600

Change 15183 merged by George Joseph:
bridge_basic: Fixed setup of recall channels

[https://gerrit.asterisk.org/c/asterisk/+/15183|https://gerrit.asterisk.org/c/asterisk/+/15183]
By: Friendly Automation (friendly-automation) 2020-11-18 10:14:54.591-0600

Change 15173 merged by George Joseph:
bridge_basic: Fixed setup of recall channels

[https://gerrit.asterisk.org/c/asterisk/+/15173|https://gerrit.asterisk.org/c/asterisk/+/15173]