Summary:	ASTERISK-29204: app_directory: Doesn't immediately accept selection
Reporter:	Michael (ringo)	Labels:	patch
Date Opened:	2020-12-08 14:40:31.000-0600	Date Closed:	2021-01-04 12:00:03.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Applications/app_directory
Versions:	13.38.0 18.1.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:	( 0) app_directory-2.patch
Description:	When using the Directory app with options: - 'm' to select from menu - 'e' also read the extension number to the caller When pressing a digit to select, while hearing the recorded name or character by character, the selection is not accepted because it just goes on to playing the extension due to option 'e'. suggestion patch attached.
Comments:	By: Asterisk Team (asteriskteam) 2020-12-08 14:40:32.140-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Michael (ringo) 2020-12-08 15:46:22.260-0600 even though this works better patched, i'm noticing now that it's still not functioning perfectly.  for example, if you wait until #3 in the menu list is playing but you press 2, it will continue with selection #2 correctly but will play the extension for the current menu entry (#3). Maybe just return res before playing extension see attached app_directory-2.patch By: Joshua C. Colp (jcolp) 2020-12-09 04:13:47.578-0600 Do you plan on putting this change up for review[1]? [1] https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process By: Joshua C. Colp (jcolp) 2020-12-09 06:54:38.649-0600 I have also had to delete the patches, as they were not marked as contributions. Contributions require a signed license agreement on file which can be done by following the "Sign a License Agreement" link at the top of JIRA. By: Michael (ringo) 2020-12-12 12:52:42.394-0600 signed, now waiting.  Thanks Josh By: Joshua C. Colp (jcolp) 2020-12-16 04:06:36.809-0600 The patch does not appear on the issue. Was your license agreement accepted? By: Michael (ringo) 2020-12-16 08:04:01.755-0600 Not exactly sure.  I received an automated email.  it's hard to tell sometimes what the email is telling you.  I decided to just try to attach the patch, checked as code, and it didn't give me the warning.  I assumed it worked. By: Joshua C. Colp (jcolp) 2020-12-17 08:36:09.851-0600 Now that you have an accepted license agreement do you plan on putting this up for review, or just keeping the patch attached? By: Michael (ringo) 2020-12-17 10:33:13.226-0600 I don't really know what that means.  I've never submitted a patch before? what is "putting this up for review"? By: Joshua C. Colp (jcolp) 2020-12-17 10:44:52.720-0600 The process is documented on the wiki[1]. [1] https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process By: Asterisk Team (asteriskteam) 2021-01-04 12:00:02.607-0600 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines