Summary:	ASTERISK-29306: strings: Incorrect use of __attribute__((pure)) in ast_str_to_lower definition
Reporter:	Vitezslav Novy (vnovy)	Labels:
Date Opened:	2021-02-20 07:40:12.000-0600	Date Closed:	2021-03-10 04:18:23.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Core/General
Versions:	16.16.1 18.2.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	debian 10,	Attachments:
Description:	I am analysing  problem with case-insensivity of application names in cel.conf declared here https://github.com/asterisk/asterisk/blob/18/main/cel.c#L75 In our configuration application CEL events are recorded only when applications are listed in cel.conf with uppercase first letter. Looking to code in cel.c application  names read from configuration shoud be converted to lowercase in function apps_handler and in function   cel_track_app app name is also converted to lowercase before it is searched in app list But it does not happen. Using few extra  logging lines I can see app name before and after calling ast_str_to_lower has first letter uppercase and ast_str_to_lower just does not work. Looking to dissasembled binary I can see the function was completely optimized out. I believe it is because of it is declared with attrribute_pure which declares no side effects. But it is not true for the function ast_str_to_lower, there are side effects. In combination with fact that function always returns value its parameter compiler is right if skips it completely and only uses the parameter of the function as its result.
Comments:	By: Asterisk Team (asteriskteam) 2021-02-20 07:40:13.205-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Sean Bright (seanbright) 2021-03-08 14:06:52.686-0600 Yup. Good catch. By: Friendly Automation (friendly-automation) 2021-03-10 04:18:26.723-0600 Change 15594 merged by Joshua Colp: strings.h: ast_str_to_upper() and _to_lower() are not pure. [https://gerrit.asterisk.org/c/asterisk/+/15594|https://gerrit.asterisk.org/c/asterisk/+/15594] By: Friendly Automation (friendly-automation) 2021-03-10 04:18:42.283-0600 Change 15577 merged by Joshua Colp: strings.h: ast_str_to_upper() and _to_lower() are not pure. [https://gerrit.asterisk.org/c/asterisk/+/15577|https://gerrit.asterisk.org/c/asterisk/+/15577] By: Friendly Automation (friendly-automation) 2021-03-10 04:18:53.665-0600 Change 15578 merged by Joshua Colp: strings.h: ast_str_to_upper() and _to_lower() are not pure. [https://gerrit.asterisk.org/c/asterisk/+/15578|https://gerrit.asterisk.org/c/asterisk/+/15578]