[Home]

Summary:ASTERISK-29513: statsd: Remove non-standard metric type Meter
Reporter:Rijnhard Hessel (rijnhard)Labels:
Date Opened:2021-07-08 03:58:32Date Closed:2021-08-03 08:12:36
Priority:MinorRegression?
Status:Closed/CompleteComponents:Resources/res_statsd
Versions:13.38.2 16.19.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Meter is a non-standard metric type
the few statsd servers that did implement it have since dropped support (specifically telegraf)

The fix is simply to change meters to counters.
Comments:By: Asterisk Team (asteriskteam) 2021-07-08 03:58:35.158-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].

By: Joshua C. Colp (jcolp) 2021-07-08 04:04:56.574-0500

Are you planning to provide a patch for this and to put it up for review?

By: Rijnhard Hessel (rijnhard) 2021-07-08 09:17:41.755-0500

Sorry about the extra spam in terms of patch sets, and anything else I may have screwed up.
My first time using gerrit and it's been a while since I last wrote C.


By: Rijnhard Hessel (rijnhard) 2021-07-08 09:18:21.102-0500

I think I am done with the changes unless you request more.

By: Friendly Automation (friendly-automation) 2021-08-03 08:12:37.319-0500

Change 16147 merged by Friendly Automation:
res_statsd: handle non-standard meter type safely

[https://gerrit.asterisk.org/c/asterisk/+/16147|https://gerrit.asterisk.org/c/asterisk/+/16147]

By: Friendly Automation (friendly-automation) 2021-08-03 08:15:32.951-0500

Change 16244 merged by Friendly Automation:
res_statsd: handle non-standard meter type safely

[https://gerrit.asterisk.org/c/asterisk/+/16244|https://gerrit.asterisk.org/c/asterisk/+/16244]

By: Friendly Automation (friendly-automation) 2021-08-03 08:18:14.864-0500

Change 16243 merged by Friendly Automation:
res_statsd: handle non-standard meter type safely

[https://gerrit.asterisk.org/c/asterisk/+/16243|https://gerrit.asterisk.org/c/asterisk/+/16243]

By: Friendly Automation (friendly-automation) 2021-08-03 08:44:51.960-0500

Change 16149 merged by George Joseph:
res_statsd: handle non-standard meter type safely

[https://gerrit.asterisk.org/c/asterisk/+/16149|https://gerrit.asterisk.org/c/asterisk/+/16149]