[Home]

Summary:ASTERISK-29531: Add SAYFILES function
Reporter:N A (InterLinked)Labels:
Date Opened:2021-07-26 12:43:36Date Closed:2021-09-14 15:02:24
Priority:MinorRegression?
Status:Closed/CompleteComponents:Functions/NewFeature
Versions:18.5.0 Frequency of
Occurrence
Related
Issues:
causesASTERISK-29816 SAY_DTMF_INTERRUPT channel variable is not honored
causesASTERISK-29859 VoiceMailMain() fails when encountering non-numeric CALLERID(num)
causesASTERISK-30248 ast_get_digit_str adds bogus initial delimiter if first character not to be spoken
Environment:Attachments:
Description:Refactors some code in say.c to allow for module API access to the underlying logic used to translate Say arguments into filenames by separating the filename logic from the playback code. Also adds a function to retrieve the files played by corresponding Say applications.
Comments:By: Asterisk Team (asteriskteam) 2021-07-26 12:43:38.578-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].

By: Friendly Automation (friendly-automation) 2021-09-10 11:45:32.371-0500

Change 16466 merged by George Joseph:
func_sayfiles: Retrieve say file names

[https://gerrit.asterisk.org/c/asterisk/+/16466|https://gerrit.asterisk.org/c/asterisk/+/16466]

By: Friendly Automation (friendly-automation) 2021-09-10 11:45:43.705-0500

Change 16467 merged by George Joseph:
func_sayfiles: Retrieve say file names

[https://gerrit.asterisk.org/c/asterisk/+/16467|https://gerrit.asterisk.org/c/asterisk/+/16467]

By: Friendly Automation (friendly-automation) 2021-09-10 11:45:54.905-0500

Change 16468 merged by George Joseph:
func_sayfiles: Retrieve say file names

[https://gerrit.asterisk.org/c/asterisk/+/16468|https://gerrit.asterisk.org/c/asterisk/+/16468]

By: Friendly Automation (friendly-automation) 2021-09-10 11:46:05.460-0500

Change 16226 merged by George Joseph:
func_sayfiles: Retrieve say file names

[https://gerrit.asterisk.org/c/asterisk/+/16226|https://gerrit.asterisk.org/c/asterisk/+/16226]

By: Shloime Rosenblum (shloimerosenblum@gmail.com) 2021-09-14 12:23:06.344-0500

Does this SAYFILES function support dates? (compare to SayDateTime)

By: N A (InterLinked) 2021-09-14 15:01:40.601-0500

SAYFILES is simply a wrapper around core say.c functions. To answer your question, no there is not. Code would need to be refactored and added to add this support.
I haven't looked at the code used by that application yet, but I do see you contributed a patch for something in say.c, so feel free to also add the support for SAYFILES if you like. Otherwise, it may end up my queue of things to work on eventually.

By: Asterisk Team (asteriskteam) 2021-09-14 15:01:41.424-0500

This issue has been reopened as a result of your commenting on it as the reporter. It will be triaged once again as applicable.