Summary:	ASTERISK-29687: Figure out the future of format_mp3 'cuz it won't compile anymore
Reporter:	George Joseph (gjoseph)	Labels:
Date Opened:	2021-10-13 07:28:25	Date Closed:	2022-03-31 13:36:48
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Addons/format_mp3
Versions:	16.21.1 18.7.1 19.0.0	Frequency of Occurrence
Related Issues:	is duplicated by ASTERISK-29712 format_mp3: GCC 11.2 found an outside array bounds is related to ASTERISK-29708 format_mp3: Clang 13 warns about the unused but set variable clip. is related to ASTERISK-29927 Make (compilation) of current Asterisk 18 fails on Ubuntu 20.04 VPS
Environment:		Attachments:
Description:	format_mp3 uses a snapped copy of mpglib that hasn't been updated in 15 years and no longer compiles.  We either need to convert it to use the system's libmpg123 or deprecate it, or something else. https://www.mpg123.de/cgi-bin/scm/mpg123/
Comments:	By: Sean Bright (seanbright) 2021-10-13 13:24:13.899-0500 bq. We either need to convert it to use the system's libmpg123 Seems like the obvious fix - maybe make it a core/extended module at the same time? By: Joshua C. Colp (jcolp) 2021-10-13 13:27:01.961-0500 The format_mp3 module is already extended support. By: Sean Bright (seanbright) 2021-10-13 14:34:19.962-0500 Can we just move the individual addons to their correct places in master? By: Alexander Traud (traud) 2021-10-29 11:58:23.748-0500 Compiles here with Clang 13 and GCC 11.2. What errors exactly do you get with which compiler on which platform? By: Sean Bright (seanbright) 2021-10-29 12:19:40.222-0500 bq. Compiles here with Clang 13 and GCC 11.2. Then I must have closed ASTERISK-29712 in error. I thought this was the same component. By: Alexander Traud (traud) 2021-10-30 03:11:19.236-0500 I am fine with closing ASTERISK-29708 and ASTERISK-29712 because this here is a superset of those (right now) and I do not have a fix for ASTERISK-29712. Although, the latter, I did not look at yet, because I do not know how to contribute to that source archive and I am using not GCC but Clang primarily. Yes, with both compilers, I get warnings, and as you stated, those turn into error in developer mode. Anyway, I would be curious what exactly is the error in this issue here. Perhaps it is something totally different. By: Joshua C. Colp (jcolp) 2022-03-29 10:30:08.919-0500 The change required to keep mpglib building is minimal. I've put a patch up to resolve the warning, as well as the unused variable patch. Once through review I'll duplicate over to SVN. If in the future someone wants to move format_mp3 to something else, then that can be done on a separate issue.