[Home]

Summary:ASTERISK-00297: [patch] Portuguese in say.c
Reporter:app (app)Labels:
Date Opened:2003-09-23 12:13:01Date Closed:2011-06-07 14:05:13
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) say.diff
Description:Include portuguese language on date, time and number functions. Change "I" option of ast_say_date_with_format to include "digits/at" which will be needed by several languages to select the apropriate equivalent voice files. This imposes a patch on app_voicemail2.c that will be reported on another feature request to support the whole voicemail in portuguese. Feminin numbers are supported by passing negative values. General cleanup.

****** ADDITIONAL INFORMATION ******

There's a test set of voice files available for the /var/lib/asterisk/sounds/pt directory. A better set will be recorded later.
Comments:By: Tilghman Lesher (tilghman) 2003-09-25 00:54:02

Looks like you've removed all absolute paths to sounds and replaced them with relative paths.  That will only work if you start asterisk from the directory where the sounds are located.  If you start Asterisk from any other path, Asterisk won't be able to find those files.

By: app (app) 2003-09-25 10:22:51

I noticed that the absolute paths were introduced very recently. I interpreted the initial idea as to use the sounds root path whenever the country language sound was not available. Anyway, why do you say that we have to start asterisk from the directory where the sounds are located? I'm starting asterisk from several locations and it works perfectly with both English and Portuguese...

By: John Todd (jtodd) 2003-09-29 03:08:34

I don't understand why this needs to be so complex, I suppose.  Is this not handled by Asterisk's current multi-language capabilities?  Are there particular problems with Portugese in the existing system, or is say.c not compliant with the multi-lingual methods already used in some other spots in Asterisk?  I fear that adding custom code for each language is not scalable.

By: app (app) 2003-09-29 06:01:28

Well... latin languages are just much more complex than English. Check bug 237 and you will see that Spanish needs about the same changes. French, Italian and others will need similar rules. I understand your concern about scaling but Asterisk won't be usable in most of the world if it just supports English. We would probably need some sort of script language where we could define the rules for each language. Or several say-xx.c's (and voicemail's) to be called by the main say.c... What do you think John?

By: Olle Johansson (oej) 2004-04-15 14:11:41

Let's find a general solution to this. Check bug 0001429

By: Olle Johansson (oej) 2004-04-15 14:31:25

Bug closed. Patch stays in archive for generalization. Let's meet at bug 1429 :-)

By: Olle Johansson (oej) 2004-04-21 03:32:19

app: I need you to send a disclaimer for this code to Digium and confirm this on bug ASTERISK-1414. If not, I will have to rip the portuguese out of the ASTERISK-1414 patch and not include it in CVS. Sorry for pushing you, but I'm in a bit of a hurry to get this sorted out.

If you have any questions, I'm available on e-mail - oej@edvina.net - or on the #asterisk-bugs channel in IRC.

/Olle

By: Olle Johansson (oej) 2004-04-21 03:32:33

--