Summary:	ASTERISK-29785: res_pjsip_sdp_rtp: Warns on every offered crypto suite
Reporter:	Alexander Traud (traud)	Labels:
Date Opened:	2021-12-03 07:37:15.000-0600	Date Closed:	2021-12-06 10:57:05.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Resources/res_pjsip_sdp_rtp
Versions:	16.21.0 18.7.0 19.0.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	With ASTERISK-29625 ([9 Sep 2021|https://github.com/asterisk/asterisk/commit/84ec6a]), Asterisk does not parse many well-known crypto suites anymore. Therefore {{res_sdp_crypto_parse_offer(.)}} does not return success for those in {{setup_sdes_srtp(.)}}. However, ASTERISK-28472 ([8 Aug 2019|https://github.com/asterisk/asterisk/commit/d4766a]) increased the verbosity in case of failure from debug to warning. That new combination [confuses …|https://community.asterisk.org/t/90495]. Ignoring = not accepting one of the possible various crypto suites is nothing to be warned about. Furthermore, because {{res_sdp_crypto_parse_offer(.)}} emits a lot of log messages, many warnings, some with highest verbosity already, I suggest to reduce the level from warning to debug in {{setup_sdes_srtp(.)}} again.
Comments:	By: Asterisk Team (asteriskteam) 2021-12-03 07:37:16.701-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Friendly Automation (friendly-automation) 2021-12-06 10:57:06.697-0600 Change 17610 merged by Friendly Automation: res_pjsip_sdp_rtp: Do not warn on unknown sRTP crypto suites. [https://gerrit.asterisk.org/c/asterisk/+/17610|https://gerrit.asterisk.org/c/asterisk/+/17610] By: Friendly Automation (friendly-automation) 2021-12-06 10:57:42.381-0600 Change 17591 merged by Friendly Automation: res_pjsip_sdp_rtp: Do not warn on unknown sRTP crypto suites. [https://gerrit.asterisk.org/c/asterisk/+/17591|https://gerrit.asterisk.org/c/asterisk/+/17591] By: Friendly Automation (friendly-automation) 2021-12-07 07:16:16.691-0600 Change 17611 merged by Joshua Colp: res_pjsip_sdp_rtp: Do not warn on unknown sRTP crypto suites. [https://gerrit.asterisk.org/c/asterisk/+/17611|https://gerrit.asterisk.org/c/asterisk/+/17611] By: Friendly Automation (friendly-automation) 2021-12-07 07:16:40.520-0600 Change 17612 merged by Joshua Colp: res_pjsip_sdp_rtp: Do not warn on unknown sRTP crypto suites. [https://gerrit.asterisk.org/c/asterisk/+/17612|https://gerrit.asterisk.org/c/asterisk/+/17612]