Summary:	ASTERISK-29869: rtp sequence number can skip after DTMF under certain bridges
Reporter:	Torrey Searle (tsearle)	Labels:
Date Opened:	2022-01-20 06:48:56.000-0600	Date Closed:	2022-01-31 07:52:38.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_rtp_asterisk
Versions:	16.7.0	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:	( 0) dtmf_gap_seq2.pcapng ( 1) patched.pcapng
Description:	while generating dtmfs, asterisk is not updating expectedseqno of packets that happen during that time. this can result in asterisk making a jump in sequence numbers after the DTMF ends when it sees expectedseqno has fallen behind of the seqno of the frames it is forwarding attached is a pcap showing the issue, filter on udp.dstport==8000 to see the rtp stream that has the jump in sequence numbers at the end of each dtmf
Comments:	By: Asterisk Team (asteriskteam) 2022-01-20 06:48:57.433-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Joshua C. Colp (jcolp) 2022-01-20 07:00:08.931-0600 Are you contributing a fix for this? By: Torrey Searle (tsearle) 2022-01-20 07:07:00.104-0600 yes, pushed to gerrit :-) By: Sean Bright (seanbright) 2022-01-20 08:17:17.109-0600 Can you attach a pcap showing the RTP streams after your patch too? By: Torrey Searle (tsearle) 2022-01-20 08:53:52.300-0600 pcap of behavior after patch attached By: Friendly Automation (friendly-automation) 2022-01-31 07:52:39.537-0600 Change 17921 merged by Friendly Automation: res/res_rtp_asterisk: fix skip in rtp sequence numbers after dtmf [https://gerrit.asterisk.org/c/asterisk/+/17921|https://gerrit.asterisk.org/c/asterisk/+/17921] By: Friendly Automation (friendly-automation) 2022-01-31 07:53:37.229-0600 Change 17928 merged by Friendly Automation: res/res_rtp_asterisk: fix skip in rtp sequence numbers after dtmf [https://gerrit.asterisk.org/c/asterisk/+/17928|https://gerrit.asterisk.org/c/asterisk/+/17928] By: Friendly Automation (friendly-automation) 2022-01-31 07:58:34.148-0600 Change 17912 merged by George Joseph: res/res_rtp_asterisk: fix skip in rtp sequence numbers after dtmf [https://gerrit.asterisk.org/c/asterisk/+/17912|https://gerrit.asterisk.org/c/asterisk/+/17912] By: Friendly Automation (friendly-automation) 2022-01-31 07:58:54.150-0600 Change 17920 merged by George Joseph: res/res_rtp_asterisk: fix skip in rtp sequence numbers after dtmf [https://gerrit.asterisk.org/c/asterisk/+/17920|https://gerrit.asterisk.org/c/asterisk/+/17920]