Summary:	ASTERISK-29905: OSX: bininstall launchd issue on cross-platfrom build
Reporter:	Sergey V. Lobanov (svlobanov)	Labels:	patch
Date Opened:	2022-02-08 16:52:19.000-0600	Date Closed:	2022-07-25 09:50:55
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	General
Versions:	GIT	Frequency of Occurrence	Constant
Related Issues:
Environment:	Build host: macos bigsur arm64 (11.6) Target host: Linux (OpenWrt GCC Toolchain)	Attachments:	( 0) 0001-build-fix-bininstall-launchd-issue-on-cross-platfrom.patch
Description:	I'm sorry but I can't send patch via gerrit.asterisk.org because asterisk legal team ignores my license agreement request (I've signed the license 9 days ago). Please review my very simple patch in this ticket. This patch can be applied to master branch (e1b050d8a3c0bf56f822e40a2c14cefc72ea50ef). I will attach the patch file in the first comment. --- configure script detects /sbin/launchd, but the result of this check is not used in Makefile (bininstall). Makefile also detects /sbin/launchd file to decide if it is required to install safe_asterisk. configure script correctly detects cross compile build and sets PBX_LAUNCHD=0 In case of building asterisk on MacOS host for Linux target using external toolchain (e.g. OpenWrt toolchain), bininstall does not install safe_asterisk (due to /sbin/launchd detection in Makefile), but it is required on target (Linux). This patch adds HAVE_SBIN_LAUNCHD=@PBX_LAUNCHD@ to makeopts.in to use the result of /sbin/launchd detection from configure script in Makefile. Also this patch uses HAVE_SBIN_LAUNCHD in Makefile (bininstall) to decide if it is required to install safe_asterisk.
Comments:	By: Asterisk Team (asteriskteam) 2022-02-08 16:52:20.768-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Sergey V. Lobanov (svlobanov) 2022-02-08 16:54:08.311-0600 <removed link to patch> By: Joshua C. Colp (jcolp) 2022-02-08 18:04:01.221-0600 Legal is currently backed up, I will ask them to review licenses as soon as possible. In the mean time I have accepted your issue report. By: Friendly Automation (friendly-automation) 2022-07-25 09:50:57.286-0500 Change 18861 merged by Friendly Automation: build: fix bininstall launchd issue on cross-platform build [https://gerrit.asterisk.org/c/asterisk/+/18861|https://gerrit.asterisk.org/c/asterisk/+/18861] By: Friendly Automation (friendly-automation) 2022-07-25 09:55:11.642-0500 Change 18859 merged by Friendly Automation: build: fix bininstall launchd issue on cross-platform build [https://gerrit.asterisk.org/c/asterisk/+/18859|https://gerrit.asterisk.org/c/asterisk/+/18859] By: Friendly Automation (friendly-automation) 2022-07-26 09:28:48.387-0500 Change 18860 merged by Joshua Colp: build: fix bininstall launchd issue on cross-platform build [https://gerrit.asterisk.org/c/asterisk/+/18860|https://gerrit.asterisk.org/c/asterisk/+/18860] By: Friendly Automation (friendly-automation) 2022-07-26 09:28:58.543-0500 Change 18858 merged by Joshua Colp: build: fix bininstall launchd issue on cross-platform build [https://gerrit.asterisk.org/c/asterisk/+/18858|https://gerrit.asterisk.org/c/asterisk/+/18858] By: Friendly Automation (friendly-automation) 2022-07-26 09:46:27.806-0500 Change 18062 merged by Joshua Colp: build: fix bininstall launchd issue on cross-platform build [https://gerrit.asterisk.org/c/asterisk/+/18062|https://gerrit.asterisk.org/c/asterisk/+/18062]