[Home]

Summary:ASTERISK-30232: Initialize stack-based ast_test_capture structures correctly
Reporter:Philip Prindeville (pprindeville)Labels:
Date Opened:2022-09-15 22:39:13Date Closed:2022-09-26 08:53:45
Priority:MinorRegression?
Status:Closed/CompleteComponents:Tests/General
Versions:16.28.0 18.14.0 19.6.0 20.0.0 Frequency of
Occurrence
Constant
Related
Issues:
Environment:Attachments:
Description:If we allocate an ast_test_capture structure and call ast_test_capture_free() without having initialized it, we may get double frees or other undefined behavior.

This structure should always be initialized before being used.
Comments:By: Asterisk Team (asteriskteam) 2022-09-15 22:39:17.175-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].

By: Joshua C. Colp (jcolp) 2022-09-16 03:27:50.704-0500

Is this something you're working on?

By: Philip Prindeville (pprindeville) 2022-09-16 14:44:28.595-0500

Yes, fixed in https://gerrit.asterisk.org/c/asterisk/+/19276.

Discovered during running /res/res_crypto/ tests and was seeing aborts from a double-free.

By: Philip Prindeville (pprindeville) 2022-09-23 12:14:25.058-0500

Ready for review.

By: Friendly Automation (friendly-automation) 2022-09-26 08:53:46.656-0500

Change 19276 merged by Friendly Automation:
test: initialize capture structure before freeing

[https://gerrit.asterisk.org/c/asterisk/+/19276|https://gerrit.asterisk.org/c/asterisk/+/19276]

By: Friendly Automation (friendly-automation) 2022-09-26 08:55:37.396-0500

Change 19343 merged by Friendly Automation:
test: initialize capture structure before freeing

[https://gerrit.asterisk.org/c/asterisk/+/19343|https://gerrit.asterisk.org/c/asterisk/+/19343]

By: Friendly Automation (friendly-automation) 2022-09-26 09:40:24.652-0500

Change 19341 merged by Friendly Automation:
test: initialize capture structure before freeing

[https://gerrit.asterisk.org/c/asterisk/+/19341|https://gerrit.asterisk.org/c/asterisk/+/19341]

By: Friendly Automation (friendly-automation) 2022-09-26 09:40:30.720-0500

Change 19344 merged by Friendly Automation:
test: initialize capture structure before freeing

[https://gerrit.asterisk.org/c/asterisk/+/19344|https://gerrit.asterisk.org/c/asterisk/+/19344]

By: Friendly Automation (friendly-automation) 2022-09-26 09:40:40.536-0500

Change 19342 merged by Friendly Automation:
test: initialize capture structure before freeing

[https://gerrit.asterisk.org/c/asterisk/+/19342|https://gerrit.asterisk.org/c/asterisk/+/19342]