| Summary: | ASTERISK-30387: res_pjsip_dialog_info_body_generator: Does not support call pickup | ||
| Reporter: | Michael Newton (miken32) | Labels: | |
| Date Opened: | 2023-01-04 16:09:24.000-0600 | Date Closed: | |
| Priority: | Minor | Regression? | |
| Status: | Open/New | Components: | Resources/res_pjsip_dialog_info_body_generator |
| Versions: | 16.29.1 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | The patch that closed ASTERISK-24601 failed to add the {{call-id}}, {{local-tag}}, and {{remote-tag}} attributes to the {{<dialog>}} element, which were previously present in chan_sip. This omission prevents native call pickup from working with Polycom phones.
SIP message with chan_sip: {noformat} NOTIFY sip:7141@192.168.0.117 SIP/2.0 Via: SIP/2.0/UDP 12.34.56.78:5060;branch=z9hG4bK2768e541;rport Max-Forwards: 70 From: <sip:7040@pbx.example.ca>;tag=as797100f8 To: "7141" <sip:7141@pbx.example.ca>;tag=DF4A420E-5CE317BB Contact: <sip:7040@12.34.56.78:5060> Call-ID: 631012da4d0d149cfdc6736329a44e18 CSeq: 115 NOTIFY User-Agent: FPBX-15.0.24(13.29.2) Subscription-State: active Event: dialog Content-Type: application/dialog-info+xml Content-Length: 615 <?xml version="1.0"?> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="13" state="full" entity="sip:7040@pbx.example.ca"> <dialog id="7040" call-id="pickup-631012da4d0d149cfdc6736329a44e18" local-tag="DF4A420E-5CE317BB" remote-tag="as797100f8" direction="recipient"> <remote> <identity display="+12505551212">sip:2505551212@pbx.example.ca</identity> <target uri="sip:2505551212@pbx.example.ca"/> </remote> <local> <identity display="Mike">sip:7040@pbx.example.ca</identity> <target uri="sip:7040@pbx.example.ca"/> </local> <state>early</state> </dialog> </dialog-info> {noformat} Message format with chan_pjsip: {noformat} NOTIFY sip:7141@56.78.90.12:5060 SIP/2.0 Via: SIP/2.0/UDP 12.34.56.78:5060;rport;branch=z9hG4bKPjcdd2ab84-8417-42fa-ae14-b18e7b8e2366 From: <sip:7040@pbx.example.ca>;tag=09f61a19-a986-4a75-91ed-81059ee9e2f8 To: "7141" <sip:7141@pbx.example.ca>;tag=22CF8F07-6565921C Contact: <sip:12.34.56.78:5060> Call-ID: e2eaf295988a9c3643e3adb561a44e18 CSeq: 2184 NOTIFY Event: dialog Subscription-State: active;expires=3516 Allow-Events: presence, dialog, message-summary, refer Max-Forwards: 70 User-Agent: FPBX-16.0.28(16.28.0) Content-Type: application/dialog-info+xml Content-Length: 553 <?xml version="1.0" encoding="UTF-8"?> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="1" state="full" entity="sip:7040@pbx.example.ca"> <dialog id="7040" direction="recipient"> <remote> <identity display="+12505551212">sip:2505551212@pbx.example.ca</identity> <target uri="sip:2505551212@pbx.example.ca"/> </remote> <local> <identity display="Mike">sip:7040@pbx.example.ca</identity> <target uri="sip:7040@pbx.example.ca"/> </local> <state>early</state> </dialog> </dialog-info> {noformat} | ||
| Comments: | By: Asterisk Team (asteriskteam) 2023-01-04 16:09:24.910-0600 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process]. Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur. Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/]. By: Joshua C. Colp (jcolp) 2023-03-21 17:15:41.617-0500 Is there a particular reason you changed the issue type? By: Michael Newton (miken32) 2023-03-21 18:15:25.336-0500 It's a regression from previous behaviour, has broken a feature that was previously working, and ASTERISK-24601 was marked as a bug (a major one at that) so it didn't seem out of line. Just got back into our chan_pjsip migration testing and was reminded of it. By: Joshua C. Colp (jcolp) 2023-03-22 03:50:43.491-0500 Previously working in chan_sip. It's never worked in chan_pjsip since it hasn't existed there, but fine - I'll leave it as a bug. | ||