[Home]

Summary:ASTERISK-30472: pbx_ael: Literal usage for variables broken
Reporter:isrl (isrl)Labels:
Date Opened:2023-03-19 07:39:59Date Closed:2023-03-24 07:14:54
Priority:CriticalRegression?Yes
Status:Closed/CompleteComponents:PBX/pbx_ael
Versions:18.17.0 Frequency of
Occurrence
Constant
Related
Issues:
is caused byASTERISK-30406 pbx_ael: Global variables are not expanded.
Environment:centosAttachments:
Description:the change in asterisk 30406 brakes existing dialplans making use of literally

we have this
   bq. STDDIALOPTION=U(destChannelActions^${ALWAYSRECORD}^${RECORDINGFORMAT}^${CONFIRM}^${CONFIRMMD5}^${ONANSWER}^${ONANSWERID}^${RECORDOTHERLEG}^${MIXMONITOROPTION})b(pjsip_header,setpjsipheader,1);

which is now broke with the change
Comments:By: Asterisk Team (asteriskteam) 2023-03-19 07:40:04.251-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].

By: ben kolodny (benphone) 2023-03-19 08:16:19.702-0500

this should of been done with a switch as it breaks backward compatibly   !
if we wanted to expand a variable we used the  eval() func .

By: isrl (isrl) 2023-03-20 03:30:38.976-0500

Sean the buffers change can probably remain
I left the buffers and just removed the expand and it seems to work ok

By: Friendly Automation (friendly-automation) 2023-03-24 07:14:58.755-0500

Change 20005 merged by Friendly Automation:
Revert "pbx_ael: Global variables are not expanded."

[https://gerrit.asterisk.org/c/asterisk/+/20005|https://gerrit.asterisk.org/c/asterisk/+/20005]

By: Friendly Automation (friendly-automation) 2023-03-24 07:15:16.741-0500

Change 20007 merged by Friendly Automation:
Revert "pbx_ael: Global variables are not expanded."

[https://gerrit.asterisk.org/c/asterisk/+/20007|https://gerrit.asterisk.org/c/asterisk/+/20007]

By: Friendly Automation (friendly-automation) 2023-03-28 10:36:40.450-0500

Change 20006 merged by Friendly Automation:
Revert "pbx_ael: Global variables are not expanded."

[https://gerrit.asterisk.org/c/asterisk/+/20006|https://gerrit.asterisk.org/c/asterisk/+/20006]

By: Friendly Automation (friendly-automation) 2023-04-03 06:11:14.471-0500

Change 20011 merged by George Joseph:
Revert "pbx_ael: Global variables are not expanded."

[https://gerrit.asterisk.org/c/asterisk/+/20011|https://gerrit.asterisk.org/c/asterisk/+/20011]

By: Friendly Automation (friendly-automation) 2023-04-03 06:11:42.912-0500

Change 20012 merged by George Joseph:
Revert "pbx_ael: Global variables are not expanded."

[https://gerrit.asterisk.org/c/asterisk/+/20012|https://gerrit.asterisk.org/c/asterisk/+/20012]