[Home]

Summary:ASTERISK-03152: [patch] Add a prompt of the count of user when joining a meetme
Reporter:mochouinard (mochouinard)Labels:
Date Opened:2005-01-01 22:59:27.000-0600Date Closed:2008-01-15 15:28:00.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme.c_announceusercount_rev2.txt
( 1) conf-onlyone.wav
( 2) conf-otherinparty.wav
( 3) conf-thereare.wav
( 4) mydiff.txt
Description:This patch will tell the user how many user is in a conference before joining it.  You will require to set the flag c to the meetme.  Also you need a new allison recording :
conf-userinconf - "User is in the conference"
conf-usersinconf - "Users are in the conference"
So when you join a conference, it will play ex: 5 users is in the conference

****** ADDITIONAL INFORMATION ******

This patch was proposed by Junk-Y

Disclamed
Comments:By: Kevin P. Fleming (kpfleming) 2005-01-01 23:08:48.000-0600

There should be two prompts for this patch.

When there is one user in the conference:

conf-userinconf - "User is in the conference"

When there is more than one user in the conference:

conf-usersinconf - "Users are in the conference"
By: mochouinard (mochouinard) 2005-01-01 23:38:22.000-0600

Thanks, patch is reuploaded, also thanks  kpfleming for the way to do the IF within a function call
By: Clod Patry (junky) 2005-01-02 00:16:17.000-0600

my idea was if there's just 1 user into the conf, si the actual sounds "you are the only person into the conference" should be prompt.
Otherwise (more then 1 person),
conf-usersinconf - "X Users are in the conference" should be prompt.

so in my mind, there's just one prompt for that patch.

Oky, after a small look at the Moc's patch, i understand your point of view kpfleming, forget what i've said.

user is into the conference, is when you join the conf and there's just one other user into the conf.

That's cool.

We'll test it tomorrow with Moc.

edited on: 01-02-05 00:20
By: Clod Patry (junky) 2005-01-02 11:35:08.000-0600

And what if we includes ourself in the count?
with that, it would save one prompt.

If there's only one person (it's you), otherwise, the prompt "X users are in the conf".
By: mochouinard (mochouinard) 2005-01-02 12:46:22.000-0600

I dont think we should include ourself in the count of user. I beleive if you call a conference, and only 1 other person is in the conference, it should say 1 user is in the conference (also you arnt in the conference yet at that point also)
By: () 2005-01-03 15:33:42.000-0600

I think we are splitting hairs on the 1 user thing. Why not just say: "There are no other users in this conference" or "You are the only user in this conference". Makes it much easier than splitting hairs over semantics.
By: mochouinard (mochouinard) 2005-01-03 15:54:05.000-0600

If your alone, it already say that you are the only one in the conference
By: () 2005-01-03 15:59:06.000-0600

Ok, sorry I didn't understand what you meant before. Sounds good.
By: Mark Spencer (markster) 2005-01-09 04:00:08.000-0600

We will need the prompts recorded in order to merge this patch.  I suggest the syntax:  "There are currently" <foo> "other participants in the conference" and "There is currently one other participant in the conference" for clarity.  Please update the patch and attach the recording from allison and I think this one is ready to go :)
By: mochouinard (mochouinard) 2005-01-10 14:53:13.000-0600

Good Idea Mark, I'll try to find how to get allison to record it.
By: Clod Patry (junky) 2005-01-10 21:11:51.000-0600

Maybe robf can do something for this bug regarding his ASTERISK-2973006 bug.
By: mochouinard (mochouinard) 2005-01-17 20:05:33.000-0600

conf-onlyone = There is currently one other participant in the conference
conf-thereare = There are currently
conf-otherinparty other participants in the conference

Please test the patch, and provide prompts ;)
By: Mark Spencer (markster) 2005-01-17 21:22:21.000-0600

Yup, we need sounds.  I only see a few things suspicious in this patch:

1) The documentation says "nnounce" instead of "announce"

2) I believe !ast_say_number is a mistake, should be ast_say_number < 0, right?

3) If you're allowing a digit to interrupt the ast_say_number, why not let it interrupt the other files too (e.g. "conf-thereare" and "conf-otherinparty"

Thanks
By: mochouinard (mochouinard) 2005-01-18 04:21:41.000-0600

Ok here is a updated version, I haven't tested it, but the code seem.. right
By: Mark Spencer (markster) 2005-01-23 03:06:14.000-0600

Code looks fine, we just need prompts in order to merge, thanks!
By: robf (robf) 2005-01-29 12:49:14.000-0600

Bug ASTERISK-3378 includes the prompts requested here (and much more).
By: Mark Spencer (markster) 2005-01-29 17:10:11.000-0600

Updated for latest CVS.  Unfortunately the correct prompts are *not* present in the large chunk merged to asterisk-sounds.  Specifically see mouchinard's comment of 01-17-05 20:05 for the files and contents:

conf-onlyone = There is currently one other participant in the conference
conf-thereare = There are currently
conf-otherinparty other participants in the conference
By: Clod Patry (junky) 2005-02-11 19:52:30.000-0600

where are we with that bug?
all prompts are added now?

It would be great to close that bug as soon as possible, since we're just waiting for the allison's prompts.
By: mochouinard (mochouinard) 2005-02-27 20:06:06.000-0600

Are anyone in or did the process of gettings the prompts ?
By: Brian West (bkw918) 2005-03-14 23:19:30.000-0600

Moc anyway we can combine all your meetme stuff into one single bug?  This is insane with 4+ bugs open with some that are never gonna make it in till we recode alot of stuff.  I'm not trying to piss anyone off but we have got to get this under 100 bugs to get mark's attention on anything new.  

/b
By: Mark Spencer (markster) 2005-03-16 18:25:46.000-0600

This doesn't need to be closed, it needs to be applied as soon as there are the properly recorded prompts to go with it.
By: mochouinard (mochouinard) 2005-03-19 12:17:43.000-0600

Thanks to bkw for the prompts (and Allison I guess too ;)

edited on: 03-19-05 12:17
By: Mark Spencer (markster) 2005-03-19 21:18:44.000-0600

Added to CVS head, thanks!
By: Russell Bryant (russell) 2005-03-28 00:50:54.000-0600

not included in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:28:00.000-0600

Repository: asterisk
Revision: 5212

U   trunk/apps/app_meetme.c
U   trunk/sounds.txt

------------------------------------------------------------------------
r5212 | markster | 2008-01-15 15:27:59 -0600 (Tue, 15 Jan 2008) | 2 lines

Add count of users in conference (bug ASTERISK-3152)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5212