Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Resources/res_features
    • Labels:
      None
    • Mantis ID:
      3241
    • Regression:
      No

      Description

      This is my attended transfer patch ported to kram's new feature API with a new bonus one touch record option.

      to use attended and blind transfer togeher

      edit features.conf and add this to [featuremap]:

      [featuremap]
      atxfer => #1
      blindxfer => #0

      now #0 is blind and #1 is attended

      to use one touch record by hitting #2 add:

      automon => #2

      To grant one touch record to a caller use w and W respectively w is for write (m and r are taken sigh)

      if the chan var TOUCH_MONITOR is set on either side of the call then that var contains the app_args for app_monitor otherwise the default of WAV||m is used

                • ADDITIONAL INFORMATION ******

      Disclaimer On File
      anthmct@yahoo.com

        Activity

        Hide
        mochouinard added a comment -

        This patch include the recording feature of ASTERISK-2922955

        edited on: 01-04-05 20:40

        Show
        mochouinard added a comment - This patch include the recording feature of ASTERISK-2922955 edited on: 01-04-05 20:40
        Hide
        Anthony Minessale added a comment -

        new version uses dialtone for both types of transfer

        Show
        Anthony Minessale added a comment - new version uses dialtone for both types of transfer
        Hide
        Mark Spencer added a comment -

        Okay, just FYI, things I changed:

        1) Use ast_ignore_pattern in dt_get

        2) Handle hangup correctly in dtget

        3) Indicate whether number is valid in return value.

        4) Mention atxfer in features.conf

        5) Minor formatting fixups

        6) Simplify silly constructs like:
        transferer->cid.cid_num ? transferer->cid.cid_num: NULL;

        7) Find a public domain beep rather than the microsoft one attached

        8) Handle '#' in dtget properly just in case someone has a dialplan with '#' in it. Still may be weird with wildcard patterns though (e.g. _9011.)

        9) Minor cleanups to automonitor

        10) Handle failure to allocate tobj (less than gracefully, I admit, but at least it won't segfault)

        11) Rename "errbeep" to "beeperr" so it gets installed by the Makefile and add to sounds.txt

        12) Update features.conf to propose some "standard" codes to activate the features.

        Please test and let me know if I missed anything!

        Show
        Mark Spencer added a comment - Okay, just FYI, things I changed: 1) Use ast_ignore_pattern in dt_get 2) Handle hangup correctly in dtget 3) Indicate whether number is valid in return value. 4) Mention atxfer in features.conf 5) Minor formatting fixups 6) Simplify silly constructs like: transferer->cid.cid_num ? transferer->cid.cid_num: NULL; 7) Find a public domain beep rather than the microsoft one attached 8) Handle '#' in dtget properly just in case someone has a dialplan with '#' in it. Still may be weird with wildcard patterns though (e.g. _9011.) 9) Minor cleanups to automonitor 10) Handle failure to allocate tobj (less than gracefully, I admit, but at least it won't segfault) 11) Rename "errbeep" to "beeperr" so it gets installed by the Makefile and add to sounds.txt 12) Update features.conf to propose some "standard" codes to activate the features. Please test and let me know if I missed anything!
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 4677

        U trunk/app.c
        U trunk/apps/app_dial.c
        U trunk/configs/features.conf.sample
        U trunk/include/asterisk/app.h
        U trunk/include/asterisk/channel.h
        U trunk/res/res_features.c
        U trunk/sounds.txt

        ------------------------------------------------------------------------
        r4677 | markster | 2008-01-15 15:20:00 -0600 (Tue, 15 Jan 2008) | 2 lines

        Merge Tony's attended # transfer with changes (bug ASTERISK-3178)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=4677

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 4677 U trunk/app.c U trunk/apps/app_dial.c U trunk/configs/features.conf.sample U trunk/include/asterisk/app.h U trunk/include/asterisk/channel.h U trunk/res/res_features.c U trunk/sounds.txt ------------------------------------------------------------------------ r4677 | markster | 2008-01-15 15:20:00 -0600 (Tue, 15 Jan 2008) | 2 lines Merge Tony's attended # transfer with changes (bug ASTERISK-3178 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4677

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development